Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 1579583003: Do not allow creation of signature classes in the background compilation path until we have the fix… (Closed)

Created:
4 years, 11 months ago by siva
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not allow creation of signature classes in the background compilation path until we have the fix from regis to not use signature classes. R=fschneider@google.com, regis@google.com Committed: https://github.com/dart-lang/sdk/commit/2a1d4234ef789e892f61d3c83aa8d79ebb4334de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
siva
4 years, 11 months ago (2016-01-12 00:04:32 UTC) #2
Florian Schneider
lgtm Lgtm. Make sure that the test IsMutatorThread works as expected with precompilation (i.e. returns ...
4 years, 11 months ago (2016-01-12 11:40:18 UTC) #3
regis
lgtm
4 years, 11 months ago (2016-01-12 16:29:27 UTC) #4
siva
On 2016/01/12 11:40:18, Florian Schneider wrote: > lgtm > > Lgtm. Make sure that the ...
4 years, 11 months ago (2016-01-12 16:33:49 UTC) #5
siva
4 years, 11 months ago (2016-01-12 16:54:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a1d4234ef789e892f61d3c83aa8d79ebb4334de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698