Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1579583003: Do not allow creation of signature classes in the background compilation path until we have the fix… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc
index f10e60ca70622f8a7ab08ec966de4db0076ca3de..c36bf537aceae275156d3662cef6e07f1461f23c 100644
--- a/runtime/vm/flow_graph_optimizer.cc
+++ b/runtime/vm/flow_graph_optimizer.cc
@@ -225,6 +225,14 @@ bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) {
// finalized yet.
return false;
}
+ // Do not run the optimization below if in background compilation since
+ // resolution of method extractor functions may create new signature
+ // classes.
+ // TODO(regis): Remove test for background compilation once signature
+ // classes are not generated any longer.
+ if (!thread()->IsMutatorThread()) {
+ return false;
+ }
const Array& args_desc_array = Array::Handle(Z,
ArgumentsDescriptor::New(call->ArgumentCount(),
call->argument_names()));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698