Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1579573002: Count feature usage for the current context instead of the calling one (Closed)

Created:
4 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 11 months ago
Reviewers:
haraken, Mike West
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, blink-reviews-bindings_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Count feature usage for the current context instead of the calling one There's no reason to attribute feature usage to the calling context instead of the current one. BUG=none R=mkwst@chromium.org,haraken@chromium.org Committed: https://crrev.com/4dce468daa519f48535c932d0b03ecf664696c3b Cr-Commit-Position: refs/heads/master@{#368580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -62 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/attributes.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/constants.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 23 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 11 months ago (2016-01-11 12:58:50 UTC) #1
haraken
LGTM I don't see any reason to use a calling context too.
4 years, 11 months ago (2016-01-11 12:59:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579573002/1
4 years, 11 months ago (2016-01-11 13:02:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 14:18:08 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 14:19:43 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4dce468daa519f48535c932d0b03ecf664696c3b
Cr-Commit-Position: refs/heads/master@{#368580}

Powered by Google App Engine
This is Rietveld 408576698