third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp - Issue 1579573002: Count feature usage for the current context instead of the calling one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 1579573002: Count feature usage for the current context instead of the calling one (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

index 13df3f8133ee92e62206dc9b2d533e37eea63572..e075f1408673000e78d55c722cbb312af0bb59c8 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

@@ -108,7 +108,7 @@ static void testInterfaceAttributeAttributeGetter(const v8::FunctionCallbackInfo

static void testInterfaceAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");

- UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::V8TestInterface_TestInterfaceAttribute_AttributeGetter);

+ UseCounter::countIfNotPrivateScript(info.GetIsolate(), currentExecutionContext(info.GetIsolate()), UseCounter::V8TestInterface_TestInterfaceAttribute_AttributeGetter);

ExecutionContext* executionContext = currentExecutionContext(info.GetIsolate());

String errorMessage;

if (!ExperimentalFeatures::featureNameEnabled(executionContext, errorMessage)) {

@@ -138,7 +138,7 @@ static void testInterfaceAttributeAttributeSetterCallback(const v8::FunctionCall

{

v8::Local<v8::Value> v8Value = info[0];

TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter");

- UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::V8TestInterface_TestInterfaceAttribute_AttributeSetter);

+ UseCounter::countIfNotPrivateScript(info.GetIsolate(), currentExecutionContext(info.GetIsolate()), UseCounter::V8TestInterface_TestInterfaceAttribute_AttributeSetter);

TestInterfaceImplementationV8Internal::testInterfaceAttributeAttributeSetter(v8Value, info);

TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}