Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1579503004: Clear integrity failure bit in PendingScript on release (Closed)

Created:
4 years, 11 months ago by jww
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Clear integrity failure bit in PendingScript on release This fixes a bug where a script loaded after a previous script failed due to an integrity failure would also fail to load. This is because the PendingScript object was reused for the new script resource, and we failed to clear out the m_integrityFailure bit. This simply sets that to false when the old script resource is released. BUG=570340 Review URL: https://codereview.chromium.org/1569823004 Cr-Commit-Position: refs/heads/master@{#368379} (cherry picked from commit 2a03de66caa66854a74e3e2fd006abbbff93ffb5) Committed: https://chromium.googlesource.com/chromium/src/+/3c29f677059758f18f74d106001306abfa0d4b99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/subresourceIntegrity/subresource-integrity-load-regular-script-after-failed-integrity.html View 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jww
4 years, 11 months ago (2016-01-11 23:08:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c29f677059758f18f74d106001306abfa0d4b99.

Powered by Google App Engine
This is Rietveld 408576698