Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1569823004: Clear integrity failure bit in PendingScript on release (Closed)

Created:
4 years, 11 months ago by jww
Modified:
4 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear integrity failure bit in PendingScript on release This fixes a bug where a script loaded after a previous script failed due to an integrity failure would also fail to load. This is because the PendingScript object was reused for the new script resource, and we failed to clear out the m_integrityFailure bit. This simply sets that to false when the old script resource is released. BUG=570340 Committed: https://crrev.com/2a03de66caa66854a74e3e2fd006abbbff93ffb5 Cr-Commit-Position: refs/heads/master@{#368379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/subresourceIntegrity/subresource-integrity-load-regular-script-after-failed-integrity.html View 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jww
sigbjornf@opera.com, would you mind taking a look at this for me? Thanks!
4 years, 11 months ago (2016-01-07 22:27:02 UTC) #2
sof
lgtm
4 years, 11 months ago (2016-01-08 13:51:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569823004/1
4 years, 11 months ago (2016-01-08 16:57:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 18:20:37 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 18:21:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a03de66caa66854a74e3e2fd006abbbff93ffb5
Cr-Commit-Position: refs/heads/master@{#368379}

Powered by Google App Engine
This is Rietveld 408576698