git cl try: load trybot list from cq.cfg by default.

git cl try: load trybot list from cq.cfg by default.

This allows "git cl try" to just work for projects without any PRESUBMIT
but with cq.cfg in default location (infra/config/cq.cfg). This also
ships all presubmit bots, since these usually fail LGTM checks anyway.

BUG=522909
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298251

[tandrii(chromium), 2016-01-13 14:49:34]

Description was changed from

==========
git cl try: load trybot list from cq.cfg by default.

This allows "git cl try" to just work for projects without any PRESUBMIT
but with cq.cfg in default location (infra/config/cq.cfg). This also
ships all presubmit bots, since these usually fail LGTM checks anyway.

BUG=
==========

to

==========
git cl try: load trybot list from cq.cfg by default.

This allows "git cl try" to just work for projects without any PRESUBMIT
but with cq.cfg in default location (infra/config/cq.cfg). This also
ships all presubmit bots, since these usually fail LGTM checks anyway.

BUG=522909
==========

[tandrii(chromium), 2016-01-13 14:49:34]

tandrii@chromium.org changed reviewers:
+ machenbach@chromium.org, sergiyb@chromium.org

[tandrii(chromium), 2016-01-13 14:50:05]

PTAL

turns out I wrote it when I filed a bug, but for some reason never uploaded,
till now that is.

[Sergiy Byelozyorov, 2016-01-13 14:53:18]

lgtm

https://codereview.chromium.org/1579423004/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1579423004/diff/1/git_cl.py#newcode45
git_cl.py:45: import commit_queue
not sure it's a good idea. this file is designed to be an executable, not a
module. perhaps it's better to move get_master_builder_map somewhere else, like
project_utils.py

[tandrii(chromium), 2016-01-13 15:16:36]

https://codereview.chromium.org/1579423004/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1579423004/diff/1/git_cl.py#newcode45
git_cl.py:45: import commit_queue
On 2016/01/13 14:53:18, Sergiy Byelozyorov wrote:
> not sure it's a good idea. this file is designed to be an executable, not a
> module. perhaps it's better to move get_master_builder_map somewhere else,
like
> project_utils.py

well, same thing with clang_format, which is also executable. So, long as
commit_queue doesn't have a weird mutable state, it's OK.

[tandrii(chromium), 2016-01-13 15:16:40]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-01-13 15:16:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579423004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579423004/1

[commit-bot: I haz the power, 2016-01-13 15:18:45]

Description was changed from

==========
git cl try: load trybot list from cq.cfg by default.

This allows "git cl try" to just work for projects without any PRESUBMIT
but with cq.cfg in default location (infra/config/cq.cfg). This also
ships all presubmit bots, since these usually fail LGTM checks anyway.

BUG=522909
==========

to

==========
git cl try: load trybot list from cq.cfg by default.

This allows "git cl try" to just work for projects without any PRESUBMIT
but with cq.cfg in default location (infra/config/cq.cfg). This also
ships all presubmit bots, since these usually fail LGTM checks anyway.

BUG=522909

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298251
==========

[commit-bot: I haz the power, 2016-01-13 15:18:45]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298251

[smut, 2016-01-25 21:16:38]

smut@google.com changed reviewers:
+ smut@google.com

[smut, 2016-01-25 21:16:39]

https://codereview.chromium.org/1579423004/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1579423004/diff/1/git_cl.py#newcode3215
git_cl.py:3215: 'infra', 'config', 'cq.cfg')
You can't hard code this path. Downstream iOS's cq.cfg is located at
ios_internal/infra/cq.cfg. With this change +
https://codereview.chromium.org/1620343003, our "git cl try" doesn't fetch try
bots from the right place at all anymore.

[Michael Achenbach, 2016-01-26 08:10:52]

Note, V8 does by now depend on this patch. If it'd just get reverted, our
git-cl-try wouldn't work anymore unless we duplicate the cq.cfg again in
PRESUBMIT.py.

[tandrii(chromium), 2016-01-26 11:41:33]

https://codereview.chromium.org/1579423004/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1579423004/diff/1/git_cl.py#newcode3215
git_cl.py:3215: 'infra', 'config', 'cq.cfg')
On 2016/01/25 21:16:38, smut wrote:
> You can't hard code this path. Downstream iOS's cq.cfg is located at
> ios_internal/infra/cq.cfg. With this change +
> https://codereview.chromium.org/1620343003, our "git cl try" doesn't fetch try
> bots from the right place at all anymore.

what do you mean I can't? I sure can and just did :)
kidding aside, I was aware of other projects, but they are a minority. For most
projects, particularly news ones, this CL is a great default behavior which does
not require action from project owners.

I don't have a solution for other projects with non-standard infra config
location. Maybe going to luci-config and loading the CQ config from there? I do
accept patches though :)