Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1620343003: src/PRESUBMIT.py: do not trigger experimental or triggered builders (Closed)

Created:
4 years, 11 months ago by Paweł Hajdan Jr.
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : even simpler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M PRESUBMIT.py View 1 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Paweł Hajdan Jr.
4 years, 11 months ago (2016-01-22 15:37:58 UTC) #2
tandrii(chromium)
On 2016/01/22 15:37:58, Paweł Hajdan Jr. wrote: Oh use what v8 has done: https://chromium.googlesource.com/v8/v8/+/master/PRESUBMIT.py (specifically ...
4 years, 11 months ago (2016-01-22 15:41:45 UTC) #3
Paweł Hajdan Jr.
On 2016/01/22 at 15:41:45, tandrii wrote: > On 2016/01/22 15:37:58, Paweł Hajdan Jr. wrote: > ...
4 years, 11 months ago (2016-01-22 15:46:26 UTC) #5
tandrii(chromium)
LGTM of course :)
4 years, 11 months ago (2016-01-22 15:47:28 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/699ec315713583756ac6cda69ddfe0b9193c8e52 Cr-Commit-Position: refs/heads/master@{#370969}
4 years, 11 months ago (2016-01-22 15:50:11 UTC) #8
Paweł Hajdan Jr.
4 years, 11 months ago (2016-01-22 15:50:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
699ec315713583756ac6cda69ddfe0b9193c8e52 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698