Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 15793007: Cutover v8 to use new style callbacks internally (Closed)

Created:
7 years, 6 months ago by dcarney
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Cutover v8 to use new style callbacks internally R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -255 lines) Patch
M samples/lineprocessor.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M samples/process.cc View 7 chunks +42 lines, -33 lines 0 comments Download
M samples/shell.cc View 3 chunks +24 lines, -21 lines 0 comments Download
M src/accessors.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/api.cc View 5 chunks +20 lines, -14 lines 0 comments Download
M src/arguments.h View 2 chunks +6 lines, -7 lines 0 comments Download
M src/d8.h View 3 chunks +48 lines, -46 lines 0 comments Download
M src/d8.cc View 8 chunks +70 lines, -59 lines 0 comments Download
M src/d8-posix.cc View 7 chunks +57 lines, -40 lines 0 comments Download
M src/extensions/externalize-string-extension.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/extensions/externalize-string-extension.cc View 2 chunks +18 lines, -14 lines 0 comments Download
M src/extensions/gc-extension.h View 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/gc-extension.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/extensions/statistics-extension.h View 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/statistics-extension.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 6 months ago (2013-06-05 12:04:29 UTC) #1
Sven Panne
lgtm
7 years, 6 months ago (2013-06-05 12:26:42 UTC) #2
dcarney
7 years, 6 months ago (2013-06-05 12:36:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14952 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698