Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1579213006: Remove unused SPDY/3 enum values. (Closed)

Created:
4 years, 11 months ago by Bence
Modified:
4 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused SPDY/3 enum values. SPDY/3 support (and test coverage) has been disabled long-long time ago, see https://crbug.com/428086. This CL cleans up some enum values that have never been used. BUG=431229 Committed: https://crrev.com/f0a42a44aef88fab98a28720118edebf7e42b60f Cr-Commit-Position: refs/heads/master@{#369655}

Patch Set 1 #

Patch Set 2 : Remove trivial comparisons; change non-trivial ones. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -27 lines) Patch
M net/http/http_response_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_server_properties.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/http/http_server_properties.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M net/socket/next_proto.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
Ryan: PTAL. Thanks.
4 years, 11 months ago (2016-01-13 18:52:32 UTC) #2
Ryan Hamilton
WOOT! lgtm
4 years, 11 months ago (2016-01-15 00:40:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579213006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579213006/20001
4 years, 11 months ago (2016-01-15 00:52:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 02:10:41 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 02:11:43 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0a42a44aef88fab98a28720118edebf7e42b60f
Cr-Commit-Position: refs/heads/master@{#369655}

Powered by Google App Engine
This is Rietveld 408576698