Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: net/spdy/spdy_network_transaction_unittest.cc

Issue 1579213006: Remove unused SPDY/3 enum values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove trivial comparisons; change non-trivial ones. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_network_transaction_unittest.cc
diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc
index d701ddb6507c275c688bff26b52e207f4dc87a9d..59951ae8f7bcf744c789d6b5cb3d3b67a8f57bdd 100644
--- a/net/spdy/spdy_network_transaction_unittest.cc
+++ b/net/spdy/spdy_network_transaction_unittest.cc
@@ -3532,7 +3532,7 @@ TEST_P(SpdyNetworkTransactionTest, NetLog) {
NetLog::PHASE_END);
// Check that we logged all the headers correctly
- const NetLog::EventType type = (GetParam().protocol <= kProtoSPDY31)
+ const NetLog::EventType type = (GetParam().protocol == kProtoSPDY31)
? NetLog::TYPE_HTTP2_SESSION_SYN_STREAM
: NetLog::TYPE_HTTP2_SESSION_SEND_HEADERS;
pos = ExpectLogContainsSomewhere(entries, 0, type, NetLog::PHASE_NONE);
@@ -6138,8 +6138,7 @@ TEST_P(SpdyNetworkTransactionTest, FlowControlStallResumeAfterSettings) {
scoped_ptr<SpdyFrame> session_window_update(
spdy_util_.ConstructSpdyWindowUpdate(0, kUploadDataSize));
- if (GetParam().protocol >= kProtoSPDY31)
- reads.push_back(CreateMockRead(*session_window_update, i++));
+ reads.push_back(CreateMockRead(*session_window_update, i++));
scoped_ptr<SpdyFrame> settings_ack(spdy_util_.ConstructSpdySettingsAck());
writes.push_back(CreateMockWrite(*settings_ack, i++));
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698