Fix bitcode parser to check type signatures of functions.

Fix bitcode parser to check type signatures of functions.

Before, type signatures of functions were only checked when called.
This CL fixes this by checking all function signatures.

BUG=None
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=bba776874b3c0cc37e43bfa58d45630f2887bc0b

[Karl, 2016-01-14 21:32:48]

Description was changed from

==========
Fix bitcode parser to check type signatures of functions.

Before, type signatures of functions were only checked when called.
This CL fixes this by checking all function signatures.

BUG=None
==========

to

==========
Fix bitcode parser to check type signatures of functions.

Before, type signatures of functions were only checked when called.
This CL fixes this by checking all function signatures.

BUG=None
==========

[Karl, 2016-01-14 21:32:48]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2016-01-14 22:59:08]

otherwise lgtm

https://codereview.chromium.org/1579203002/diff/80001/src/IceGlobalInits.h
File src/IceGlobalInits.h (right):

https://codereview.chromium.org/1579203002/diff/80001/src/IceGlobalInits.h#ne...
src/IceGlobalInits.h:160: /// Validates that type signature of function is
correct. Returns true if
How about "the type signature" and "the function"?

https://codereview.chromium.org/1579203002/diff/80001/src/IceGlobalInits.h#ne...
src/IceGlobalInits.h:161: /// valid,
End sentence with a period, or fill in the missing remainder. :)

https://codereview.chromium.org/1579203002/diff/80001/src/IceGlobalInits.h#ne...
src/IceGlobalInits.h:170: /// Generates error message describing why
validateTypeSignature returns
an error message

https://codereview.chromium.org/1579203002/diff/80001/src/IceGlobalInits.h#ne...
src/IceGlobalInits.h:184: getIntrinsicInfo(const GlobalContext *Ctx, bool
&IsIntrinsic) const;
I'm guessing John is going to ask for bool* here.

https://codereview.chromium.org/1579203002/diff/80001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1579203002/diff/80001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:644: for (const auto FuncDecl : FunctionDeclarations) {
I would use Ice::FunctionDeclaration* instead of auto.

[Karl, 2016-01-15 15:33:19]

Description was changed from

==========
Fix bitcode parser to check type signatures of functions.

Before, type signatures of functions were only checked when called.
This CL fixes this by checking all function signatures.

BUG=None
==========

to

==========
Fix bitcode parser to check type signatures of functions.

Before, type signatures of functions were only checked when called.
This CL fixes this by checking all function signatures.

BUG=None
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-01-15 15:33:20]

Committed patchset #6 (id:100001) manually as
bba776874b3c0cc37e43bfa58d45630f2887bc0b (presubmit successful).

[Karl, 2016-01-15 15:33:34]

https://codereview.chromium.org/1579203002/diff/80001/src/IceGlobalInits.h
File src/IceGlobalInits.h (right):

https://codereview.chromium.org/1579203002/diff/80001/src/IceGlobalInits.h#ne...
src/IceGlobalInits.h:160: /// Validates that type signature of function is
correct. Returns true if
On 2016/01/14 22:59:08, stichnot wrote:
> How about "the type signature" and "the function"?

Done.

https://codereview.chromium.org/1579203002/diff/80001/src/IceGlobalInits.h#ne...
src/IceGlobalInits.h:161: /// valid,
On 2016/01/14 22:59:08, stichnot wrote:
> End sentence with a period, or fill in the missing remainder. :)

Done.

https://codereview.chromium.org/1579203002/diff/80001/src/IceGlobalInits.h#ne...
src/IceGlobalInits.h:170: /// Generates error message describing why
validateTypeSignature returns
On 2016/01/14 22:59:08, stichnot wrote:
> an error message

Done.

https://codereview.chromium.org/1579203002/diff/80001/src/IceGlobalInits.h#ne...
src/IceGlobalInits.h:184: getIntrinsicInfo(const GlobalContext *Ctx, bool
&IsIntrinsic) const;
On 2016/01/14 22:59:08, stichnot wrote:
> I'm guessing John is going to ask for bool* here.

Changed to use bool *.

https://codereview.chromium.org/1579203002/diff/80001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1579203002/diff/80001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:644: for (const auto FuncDecl : FunctionDeclarations) {
On 2016/01/14 22:59:08, stichnot wrote:
> I would use Ice::FunctionDeclaration* instead of auto.

Done.