src/IceConverter.cpp - Issue 1579203002: Fix bitcode parser to check type signatures of functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceConverter.cpp

Issue 1579203002: Fix bitcode parser to check type signatures of functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Commit patch. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceConverter.cpp

diff --git a/src/IceConverter.cpp b/src/IceConverter.cpp

index 0907167ae526055b9d7193ca4fb61c482edc69fd..e54dd2a0403354a2cec808e18c8693392a24ccd1 100644

--- a/src/IceConverter.cpp

+++ b/src/IceConverter.cpp

@@ -880,6 +880,8 @@ void Converter::installGlobalDeclarations(Module *Mod) {

StrBuf << "\n Use flag -allow-externally-defined-symbols to override";

report_fatal_error(StrBuf.str());

}

+ if (!IceFunc->validateTypeSignature(Ctx))

+ report_fatal_error(IceFunc->getTypeSignatureError(Ctx));

GlobalDeclarationMap[&Func] = IceFunc;

}

// Install global variable declarations.

« no previous file with comments | « no previous file | src/IceGlobalInits.h » ('j') | no next file with comments »