gpu: Autogenerate glHint state

gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

Index: gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h b/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
index f021ef312ac1afdbe659ab5d33d0ab5d56b51c77..7849879d6da7919bb1187b1a9abf409b2ad99d06 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
@@ -1407,7 +1407,15 @@ error::Error GLES2DecoderImpl::HandleHint(
     LOCAL_SET_GL_ERROR_INVALID_ENUM("glHint", mode, "mode");
     return error::kNoError;
   }
-  DoHint(target, mode);
+  if (target == GL_GENERATE_MIPMAP_HINT &&

[greggman, 2013/05/30 19:57:16]

Does it make sense to change this to a switch/case or at least make the ifs
cascade? As it is, if the mode is the same it will end up checking the other
targets

In other words

    if (target == GL_GENERATE_MIPMAP_HINT) {
      if (state_.hint_generate_mipmap != mode) {
        state_.hint_generate_mapmap = mode
      }
    } else if (target == GL_FRAGMENT_SHADER_DERIVATIVE_HINT) {
      ...

or

    switch (target) {
      case GL_GENERATE_MIPMAP_HINT:
        if (state_.hint_generate_mipmap != mode) {
          state_.hint_generate_mapmap = mode
        }
        break;

etc..

I know this code is not perf sensitive but someone will copy it later to a place
that is.

[Sami, 2013/05/31 09:40:20]

Great point, let's try to maintain a high standard for generated code. I've made
this into a switch-case.

+      state_.hint_generate_mipmap != mode) {
+    state_.hint_generate_mipmap = mode;
+    glHint(target, mode);
+  } else if (target == GL_FRAGMENT_SHADER_DERIVATIVE_HINT_OES &&
+      state_.hint_fragment_shader_derivative != mode) {
+    state_.hint_fragment_shader_derivative = mode;
+    glHint(target, mode);
+  }
   return error::kNoError;
 }