gpu: Autogenerate glHint state

gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is auto-generated from
 // gpu/command_buffer/build_gles2_cmd_buffer.py
 // DO NOT EDIT!
 
 // It is included by gles2_cmd_decoder.cc
 #ifndef GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_AUTOGEN_H_
@@ skipping 1389 matching lines @@
   GLenum target = static_cast<GLenum>(c.target);
   GLenum mode = static_cast<GLenum>(c.mode);
   if (!validators_->hint_target.IsValid(target)) {
     LOCAL_SET_GL_ERROR_INVALID_ENUM("glHint", target, "target");
     return error::kNoError;
   }
   if (!validators_->hint_mode.IsValid(mode)) {
     LOCAL_SET_GL_ERROR_INVALID_ENUM("glHint", mode, "mode");
     return error::kNoError;
   }
-  DoHint(target, mode);
+  if (target == GL_GENERATE_MIPMAP_HINT &&

[greggman, 2013/05/30 19:57:16]

Does it make sense to change this to a switch/case or at least make the ifs
cascade? As it is, if the mode is the same it will end up checking the other
targets

In other words

    if (target == GL_GENERATE_MIPMAP_HINT) {
      if (state_.hint_generate_mipmap != mode) {
        state_.hint_generate_mapmap = mode
      }
    } else if (target == GL_FRAGMENT_SHADER_DERIVATIVE_HINT) {
      ...

or

    switch (target) {
      case GL_GENERATE_MIPMAP_HINT:
        if (state_.hint_generate_mipmap != mode) {
          state_.hint_generate_mapmap = mode
        }
        break;

etc..

I know this code is not perf sensitive but someone will copy it later to a place
that is.

[Sami, 2013/05/31 09:40:20]

Great point, let's try to maintain a high standard for generated code. I've made
this into a switch-case.

+      state_.hint_generate_mipmap != mode) {
+    state_.hint_generate_mipmap = mode;
+    glHint(target, mode);
+  } else if (target == GL_FRAGMENT_SHADER_DERIVATIVE_HINT_OES &&
+      state_.hint_fragment_shader_derivative != mode) {
+    state_.hint_fragment_shader_derivative = mode;
+    glHint(target, mode);
+  }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleIsBuffer(
     uint32 immediate_data_size, const gles2::cmds::IsBuffer& c) {
   GLuint buffer = c.buffer;
   typedef cmds::IsBuffer::Result Result;
   Result* result_dst = GetSharedMemoryAs<Result*>(
       c.result_shm_id, c.result_shm_offset, sizeof(*result_dst));
   if (!result_dst) {
@@ skipping 1887 matching lines @@
         clear_state_dirty_ = true;
       }
       return false;
     default:
       NOTREACHED();
       return false;
   }
 }
 #endif  // GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_AUTOGEN_H_