Convert GrAuditTrail to use scoped frames

Convert GrAuditTrail to use scoped frames

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1579193002

Committed: https://skia.googlesource.com/skia/+/87a721b2465c9ccfa191ce9f5012f92be7731fbc

[joshua.litt, 2016-01-12 15:37:56]

Description was changed from

==========
Convert GrAuditTrail to use scoped frames

BUG=skia:
==========

to

==========
Convert GrAuditTrail to use scoped frames

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-01-12 15:40:52]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[joshualitt, 2016-01-12 15:40:53]

This CL converts GrAuditTrail to use a much more flexible tree of scoped frames.
 This model will be flexible enough to elegantly handle clipping.

Its a bit buggy right now because we need to ensure every call site of
addDrawBatch needs to be converted over to use GrAuditTrail.  I will do this in
the follow on

[bsalomon, 2016-01-12 15:46:40]

Two questions:

1) Should we use static char* to avoid all the string copying?

2) Should each Frame get a uniqueID so we can reconstruct the callgraph in a
tool?

[robertphillips, 2016-01-12 15:56:21]

https://codereview.chromium.org/1579193002/diff/1/include/private/GrAuditTrail.h
File include/private/GrAuditTrail.h (right):

https://codereview.chromium.org/1579193002/diff/1/include/private/GrAuditTrai...
include/private/GrAuditTrail.h:73: private:
// A Frame can have either batches or children but not both

?

[joshualitt, 2016-01-12 15:59:09]

On 2016/01/12 15:56:21, robertphillips wrote:
>
https://codereview.chromium.org/1579193002/diff/1/include/private/GrAuditTrail.h
> File include/private/GrAuditTrail.h (right):
> 
>
https://codereview.chromium.org/1579193002/diff/1/include/private/GrAuditTrai...
> include/private/GrAuditTrail.h:73: private:
> // A Frame can have either batches or children but not both
> 
> ?

I guess that is technically not true.  In a follow on CL I will make a single
array / union type so that we can intersperse batches with more stack frames.

[joshualitt, 2016-01-12 16:23:07]

On 2016/01/12 15:59:09, joshualitt wrote:
> On 2016/01/12 15:56:21, robertphillips wrote:
> >
>
https://codereview.chromium.org/1579193002/diff/1/include/private/GrAuditTrail.h
> > File include/private/GrAuditTrail.h (right):
> > 
> >
>
https://codereview.chromium.org/1579193002/diff/1/include/private/GrAuditTrai...
> > include/private/GrAuditTrail.h:73: private:
> > // A Frame can have either batches or children but not both
> > 
> > ?
> 
> I guess that is technically not true.  In a follow on CL I will make a single
> array / union type so that we can intersperse batches with more stack frames.

feedback incorporated

[bsalomon, 2016-01-12 19:51:13]

lgtm

https://codereview.chromium.org/1579193002/diff/40001/include/private/GrAudit...
File include/private/GrAuditTrail.h (right):

https://codereview.chromium.org/1579193002/diff/40001/include/private/GrAudit...
include/private/GrAuditTrail.h:84: // TODO combine these into a single array
Is this in order to preserve the sequence?

[joshualitt, 2016-01-12 20:47:16]

On 2016/01/12 19:51:13, bsalomon wrote:
> lgtm
> 
>
https://codereview.chromium.org/1579193002/diff/40001/include/private/GrAudit...
> File include/private/GrAuditTrail.h (right):
> 
>
https://codereview.chromium.org/1579193002/diff/40001/include/private/GrAudit...
> include/private/GrAuditTrail.h:84: // TODO combine these into a single array
> Is this in order to preserve the sequence?
Yes, it'd be nice I think in the odd case where we do mix batches and calls down
the stack to see the order perserved.

[joshualitt, 2016-01-12 20:47:48]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-01-12 20:47:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579193002/40001

[commit-bot: I haz the power, 2016-01-12 20:59:30]

Description was changed from

==========
Convert GrAuditTrail to use scoped frames

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Convert GrAuditTrail to use scoped frames

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/87a721b2465c9ccfa191ce9f5012f92be7731fbc
==========

[commit-bot: I haz the power, 2016-01-12 20:59:31]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/87a721b2465c9ccfa191ce9f5012f92be7731fbc