Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1577093003: Add batch names and bounds to json debug information (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@audittrail-wireupcontext
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : disable output #

Total comments: 2

Patch Set 3 : remove debug print #

Patch Set 4 : constify #

Patch Set 5 : extra newline #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -28 lines) Patch
M include/private/GrAuditTrail.h View 1 2 3 4 4 chunks +19 lines, -2 lines 0 comments Download
M src/gpu/GrAuditTrail.cpp View 1 chunk +104 lines, -14 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 3 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 4 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 5 2 chunks +1 line, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
joshualitt
This CL adds bounds and batch names to the associated ops. I also added a ...
4 years, 11 months ago (2016-01-11 20:58:02 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1577093003/diff/20001/include/private/GrAuditTrail.h File include/private/GrAuditTrail.h (right): https://codereview.chromium.org/1577093003/diff/20001/include/private/GrAuditTrail.h#newcode26 include/private/GrAuditTrail.h:26: const SkString& name ? https://codereview.chromium.org/1577093003/diff/20001/include/private/GrAuditTrail.h#newcode60 include/private/GrAuditTrail.h:60: #define GR_AUDIT_TRAIL_ADDOP(audit_trail, ...
4 years, 11 months ago (2016-01-11 21:13:55 UTC) #4
joshualitt
On 2016/01/11 21:13:55, robertphillips wrote: > lgtm > > https://codereview.chromium.org/1577093003/diff/20001/include/private/GrAuditTrail.h > File include/private/GrAuditTrail.h (right): > ...
4 years, 11 months ago (2016-01-11 21:18:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577093003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577093003/80001
4 years, 11 months ago (2016-01-12 14:32:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/5195)
4 years, 11 months ago (2016-01-12 14:32:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577093003/70007 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577093003/70007
4 years, 11 months ago (2016-01-12 14:35:17 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 14:45:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #6 (id:70007) as
https://skia.googlesource.com/skia/+/086cee12deaf9a9f46bbd2e52173e0e4fc4df311

Powered by Google App Engine
This is Rietveld 408576698