Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1578853002: [m48 merge] Remove clientWidth call during MediaControls::reset. (Closed)

Created:
4 years, 11 months ago by liberato (no reviews please)
Modified:
4 years, 11 months ago
Reviewers:
philipj_slow
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Remove clientWidth call during MediaControls::reset. This is a merge to M48 of f003b7d5f0f8667873a8f152d5a06512d3bded9c . Avoid calling clientWidth early to get the control panel width. It can cause a crash when the HitTestCache is cleared, if the cache was the last holder to the media element. Normally, this can't happen, but a callback from the WebMediaPlayer can be scheduled between the cache becoming the last reference and the next layout. BUG=531259 NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Patch Set 2 : nopresubmit / notry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 3 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
liberato (no reviews please)
4 years, 11 months ago (2016-01-11 19:10:44 UTC) #3
philipj_slow
lgtm
4 years, 11 months ago (2016-01-12 15:15:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578853002/1
4 years, 11 months ago (2016-01-12 15:16:02 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 11 months ago (2016-01-12 15:16:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578853002/20001
4 years, 11 months ago (2016-01-12 17:50:22 UTC) #11
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 11 months ago (2016-01-12 17:50:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578853002/20001
4 years, 11 months ago (2016-01-12 17:51:37 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 17:53:39 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698