Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

Issue 1578853002: [m48 merge] Remove clientWidth call during MediaControls::reset. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2564
Patch Set: nopresubmit / notry Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MediaControls.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/html/shadow/MediaControls.h" 6 #include "core/html/shadow/MediaControls.h"
7 7
8 #include "core/HTMLNames.h" 8 #include "core/HTMLNames.h"
9 #include "core/css/StylePropertySet.h" 9 #include "core/css/StylePropertySet.h"
10 #include "core/dom/Document.h" 10 #include "core/dom/Document.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 return true; 49 return true;
50 } 50 }
51 51
52 } // namespace 52 } // namespace
53 53
54 class MediaControlsTest : public testing::Test { 54 class MediaControlsTest : public testing::Test {
55 protected: 55 protected:
56 virtual void SetUp() 56 virtual void SetUp()
57 { 57 {
58 m_pageHolder = DummyPageHolder::create(IntSize(800, 600)); 58 m_pageHolder = DummyPageHolder::create(IntSize(800, 600));
59 Document& document = m_pageHolder->document(); 59 Document& document = this->document();
60 document.write("<video controls>"); 60 document.write("<video controls>");
61 HTMLVideoElement& video = toHTMLVideoElement(*document.querySelector("vi deo", ASSERT_NO_EXCEPTION)); 61 HTMLVideoElement& video = toHTMLVideoElement(*document.querySelector("vi deo", ASSERT_NO_EXCEPTION));
62 m_mediaControls = video.mediaControls(); 62 m_mediaControls = video.mediaControls();
63 } 63 }
64 64
65 MediaControls& mediaControls() { return *m_mediaControls; } 65 MediaControls& mediaControls() { return *m_mediaControls; }
66 Document& document() { return m_pageHolder->document(); }
66 67
67 private: 68 private:
68 OwnPtr<DummyPageHolder> m_pageHolder; 69 OwnPtr<DummyPageHolder> m_pageHolder;
69 MediaControls* m_mediaControls; 70 MediaControls* m_mediaControls;
70 }; 71 };
71 72
72 TEST_F(MediaControlsTest, HideAndShow) 73 TEST_F(MediaControlsTest, HideAndShow)
73 { 74 {
74 Element* panel = getElementByShadowPseudoId(mediaControls(), "-webkit-media- controls-panel"); 75 Element* panel = getElementByShadowPseudoId(mediaControls(), "-webkit-media- controls-panel");
75 ASSERT_NE(nullptr, panel); 76 ASSERT_NE(nullptr, panel);
(...skipping 20 matching lines...) Expand all
96 Element* panel = getElementByShadowPseudoId(mediaControls(), "-webkit-media- controls-panel"); 97 Element* panel = getElementByShadowPseudoId(mediaControls(), "-webkit-media- controls-panel");
97 ASSERT_NE(nullptr, panel); 98 ASSERT_NE(nullptr, panel);
98 99
99 ASSERT_TRUE(isElementVisible(*panel)); 100 ASSERT_TRUE(isElementVisible(*panel));
100 mediaControls().hide(); 101 mediaControls().hide();
101 ASSERT_FALSE(isElementVisible(*panel)); 102 ASSERT_FALSE(isElementVisible(*panel));
102 mediaControls().reset(); 103 mediaControls().reset();
103 ASSERT_FALSE(isElementVisible(*panel)); 104 ASSERT_FALSE(isElementVisible(*panel));
104 } 105 }
105 106
107 TEST_F(MediaControlsTest, ResetDoesNotTriggerInitialLayout)
108 {
109 Document& document = this->document();
110 int oldResolverCount = document.styleEngine().resolverAccessCount();
111 // Also assert that there are no layouts yet.
112 ASSERT_EQ(0, oldResolverCount);
113 mediaControls().reset();
114 int newResolverCount = document.styleEngine().resolverAccessCount();
115 ASSERT_EQ(oldResolverCount, newResolverCount);
116 }
117
106 } // namespace blink 118 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MediaControls.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698