Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1578813002: Revert of Disable map in Work Chrome (Closed)

Created:
4 years, 11 months ago by vichang1
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable map in Work Chrome (patchset #3 id:40001 of https://codereview.chromium.org/1544783002/ ) Reason for revert: Revert this CL to fix crbug.com/575092. Original issue's description: > Disable mmap in sqlite for Work Chrome build > > BUG=554269 > > Committed: https://crrev.com/3ab540e9295d58cef97cc56533498420abb4a3ff > Cr-Commit-Position: refs/heads/master@{#367054} TBR=shess@chromium.org,michaeln@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=554269 Committed: https://crrev.com/f594a1085b49369c2479e5526dd0ef8b116e9af0 Cr-Commit-Position: refs/heads/master@{#368692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -32 lines) Patch
M third_party/sqlite/BUILD.gn View 2 chunks +7 lines, -14 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 2 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
vichang1
Created Revert of Disable map in Work Chrome
4 years, 11 months ago (2016-01-11 17:48:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578813002/1
4 years, 11 months ago (2016-01-11 17:50:14 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 11 months ago (2016-01-11 17:50:18 UTC) #6
amineer_google
On 2016/01/11 17:50:18, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 11 months ago (2016-01-11 17:50:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578813002/1
4 years, 11 months ago (2016-01-11 17:53:49 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 11 months ago (2016-01-11 17:53:50 UTC) #11
Yaron
On 2016/01/11 17:53:50, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 11 months ago (2016-01-11 20:48:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578813002/1
4 years, 11 months ago (2016-01-11 20:52:19 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 22:29:52 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 22:30:55 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f594a1085b49369c2479e5526dd0ef8b116e9af0
Cr-Commit-Position: refs/heads/master@{#368692}

Powered by Google App Engine
This is Rietveld 408576698