Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/sqlite/sqlite.gyp

Issue 1578813002: Revert of Disable map in Work Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/sqlite/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/sqlite/sqlite.gyp
diff --git a/third_party/sqlite/sqlite.gyp b/third_party/sqlite/sqlite.gyp
index db9df69169d62c18d1ea59e9b17bae9a6afeb9c0..d0357b7de70e5f3dcbb38431618cb639c1d4c108 100644
--- a/third_party/sqlite/sqlite.gyp
+++ b/third_party/sqlite/sqlite.gyp
@@ -28,6 +28,12 @@
# appropriately. Chromium doesn't configure SQLite for that, and would
# prefer to control distribution to worker threads.
'SQLITE_MAX_WORKER_THREADS=0',
+ # Allow 256MB mmap footprint per connection. Should not be too open-ended
+ # as that could cause memory fragmentation. 50MB encompasses the 99th
+ # percentile of Chrome databases in the wild.
+ # TODO(shess): A 64-bit-specific value could be 1G or more.
+ # TODO(shess): Figure out if exceeding this is costly.
+ 'SQLITE_MAX_MMAP_SIZE=268435456',
# Use a read-only memory map when mmap'ed I/O is enabled to prevent memory
# stompers from directly corrupting the database.
# TODO(shess): Upstream the ability to use this define.
@@ -246,23 +252,5 @@
},
],
}],
- ['android_channel == "work"', {
- 'target_defaults': {
- 'defines': [
- 'SQLITE_MAX_MMAP_SIZE=0',
- ],
- },
- }, { # else: android_channel != "work"
- 'target_defaults': {
- 'defines': [
- # Allow 256MB mmap footprint per connection. Should not be too open-ended
- # as that could cause memory fragmentation. 50MB encompasses the 99th
- # percentile of Chrome databases in the wild.
- # TODO(shess): A 64-bit-specific value could be 1G or more.
- # TODO(shess): Figure out if exceeding this is costly.
- 'SQLITE_MAX_MMAP_SIZE=268435456',
- ],
- },
- }],
],
}
« no previous file with comments | « third_party/sqlite/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698