Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1578763003: Oilpan: fix uninitialized pointers following r368596. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: fix uninitialized pointers following r368596. R=haraken,timloh BUG=499780 NOTRY=true Committed: https://crrev.com/e19d079c6518df6659a6385150bf4166fc2a6a6e Cr-Commit-Position: refs/heads/master@{#368824}

Patch Set 1 #

Patch Set 2 : fix array size calc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sof
oilpan ToT has been broken for the past 12hours+.
4 years, 11 months ago (2016-01-12 07:11:24 UTC) #1
haraken
LGTM
4 years, 11 months ago (2016-01-12 07:14:58 UTC) #2
Timothy Loh
On 2016/01/12 07:11:24, sof wrote: > oilpan ToT has been broken for the past 12hours+. ...
4 years, 11 months ago (2016-01-12 07:18:47 UTC) #3
sof
On 2016/01/12 07:18:47, Timothy Loh wrote: > On 2016/01/12 07:11:24, sof wrote: > > oilpan ...
4 years, 11 months ago (2016-01-12 07:37:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578763003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578763003/20001
4 years, 11 months ago (2016-01-12 07:38:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-12 08:41:50 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e19d079c6518df6659a6385150bf4166fc2a6a6e Cr-Commit-Position: refs/heads/master@{#368824}
4 years, 11 months ago (2016-01-12 08:42:49 UTC) #11
sof
4 years, 11 months ago (2016-01-12 10:32:27 UTC) #12
Message was sent while issue was closed.
On 2016/01/12 07:37:08, sof wrote:
> On 2016/01/12 07:18:47, Timothy Loh wrote:
> > On 2016/01/12 07:11:24, sof wrote:
> > > oilpan ToT has been broken for the past 12hours+.
> > 
> > lgtm
> 
> thanks, will land this. There are two other issues (canvas crashes + dynamic
> linking failure) w/ ToT as well, but will handle those separately.

Looks like we're back in green mostly; the dynamic linker failures are expected
temporary regressions following https://codereview.chromium.org/1539373005 so
will let those be.

Powered by Google App Engine
This is Rietveld 408576698