Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1539373005:
roll clang 255169:256316 (Closed)
|
Created:
5 years ago by Nico Modified:
4 years, 11 months ago Reviewers:
hans CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionroll clang 255169:256316
New:
* /W4 in clang-cl enables -Wextra warnings
* fix for link.exe /incremental build flakes
* /Brepro suppresses timestamps for deterministic builds
(doesn't work with link.exe /incremental)
Note that this brings in a libc++ regression on Mac [1]: some of the
symbols that are hidden symbols in the system libc++ in OS X 10.8
are marked as "inline" in the headers shipped with this compiler --
this means that binaries produced by this compiler might not run
on OS X 10.8 if these calls don't get inlined (or, if the 10.8 SDK is
used, they won't link). That's ok for us though because production
builds on OS X statically link a newer libc++ with these symbols
exported, the iOS bots run newer OS X versions than 10.8, and
so do the Mac bots that do component builds (which use the
system libc++) or asan builds. And soon we'll roll in r257193 which
fixes this again.
1: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160104/146428.html
BUG=571691
TBR=hans
Committed: https://crrev.com/483df9304bb678dd50b435a41c063a3aed96d10f
Cr-Commit-Position: refs/heads/master@{#368796}
Patch Set 1 #Patch Set 2 : 256307 #Patch Set 3 : 256308 #Patch Set 4 : precise binary #Patch Set 5 : 256315 #Patch Set 6 : . #Patch Set 7 : 316 #Patch Set 8 : retry #Patch Set 9 : retry #Patch Set 10 : retry #
Total comments: 1
Messages
Total messages: 77 (41 generated)
Description was changed from ========== roll clang 255167:256248 BUG=571691 ========== to ========== roll clang 255167:256307 BUG=571691 ==========
Description was changed from ========== roll clang 255167:256307 BUG=571691 ========== to ========== roll clang 255167:256308 New: /W4 in clang-cl enables -Wextra warnings fix for link.exe /incremental build flakes /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) BUG=571691 ==========
Description was changed from ========== roll clang 255167:256308 New: /W4 in clang-cl enables -Wextra warnings fix for link.exe /incremental build flakes /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) BUG=571691 ========== to ========== roll clang 255167:256308 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) The linux binary was built on trusty. All previous binaries were built on precise. If this is a problem for some of your bots, please let me know -- I also pushed a precise binary to goma (version -2), but if possible I'd prefer if we could start building binaries on trusty. Hans spot-checked a few bots and it seems to be fine there, but there are always many bots we don't know about. BUG=571691 ==========
Description was changed from ========== roll clang 255167:256308 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) The linux binary was built on trusty. All previous binaries were built on precise. If this is a problem for some of your bots, please let me know -- I also pushed a precise binary to goma (version -2), but if possible I'd prefer if we could start building binaries on trusty. Hans spot-checked a few bots and it seems to be fine there, but there are always many bots we don't know about. BUG=571691 ========== to ========== roll clang 255167:256308 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) The linux binary was built on trusty. All previous binaries were built on precise. If this is a problem for some of your bots, please let me know -- I also pushed a precise binary to goma (version -2), but if possible I'd prefer if we could start building binaries on trusty. Hans spot-checked a few bots and it seems to be fine there, but there are always many bots we don't know about. BUG=571691 TBR=hans ==========
thakis@chromium.org changed reviewers: + hans@chromium.org
Description was changed from ========== roll clang 255167:256308 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) The linux binary was built on trusty. All previous binaries were built on precise. If this is a problem for some of your bots, please let me know -- I also pushed a precise binary to goma (version -2), but if possible I'd prefer if we could start building binaries on trusty. Hans spot-checked a few bots and it seems to be fine there, but there are always many bots we don't know about. BUG=571691 TBR=hans ========== to ========== roll clang 255167:256315 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) The linux binary was built on trusty. All previous binaries were built on precise. If this is a problem for some of your bots, please let me know -- I also pushed a precise binary to goma (version -2), but if possible I'd prefer if we could start building binaries on trusty. Hans spot-checked a few bots and it seems to be fine there, but there are always many bots we don't know about. BUG=571691 TBR=hans ==========
Description was changed from ========== roll clang 255167:256315 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) The linux binary was built on trusty. All previous binaries were built on precise. If this is a problem for some of your bots, please let me know -- I also pushed a precise binary to goma (version -2), but if possible I'd prefer if we could start building binaries on trusty. Hans spot-checked a few bots and it seems to be fine there, but there are always many bots we don't know about. BUG=571691 TBR=hans ========== to ========== roll clang 255167:256315 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) BUG=571691 TBR=hans ==========
Description was changed from ========== roll clang 255167:256315 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) BUG=571691 TBR=hans ========== to ========== roll clang 255167:256316 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) BUG=571691 TBR=hans ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
https://codereview.chromium.org/1539373005/diff/180001/tools/clang/scripts/up... File tools/clang/scripts/update.py (left): https://codereview.chromium.org/1539373005/diff/180001/tools/clang/scripts/up... tools/clang/scripts/update.py:29: CLANG_REVISION = '255169' the message says it's a roll from 255167, not 169
Description was changed from ========== roll clang 255167:256316 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) BUG=571691 TBR=hans ========== to ========== roll clang 255169:256316 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) BUG=571691 TBR=hans ==========
On 2016/01/05 11:05:53, hans wrote: > https://codereview.chromium.org/1539373005/diff/180001/tools/clang/scripts/up... > File tools/clang/scripts/update.py (left): > > https://codereview.chromium.org/1539373005/diff/180001/tools/clang/scripts/up... > tools/clang/scripts/update.py:29: CLANG_REVISION = '255169' > the message says it's a roll from 255167, not 169 Done
On 2016/01/05 11:05:53, hans wrote: > https://codereview.chromium.org/1539373005/diff/180001/tools/clang/scripts/up... > File tools/clang/scripts/update.py (left): > > https://codereview.chromium.org/1539373005/diff/180001/tools/clang/scripts/up... > tools/clang/scripts/update.py:29: CLANG_REVISION = '255169' > the message says it's a roll from 255167, not 169 Done
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
Description was changed from ========== roll clang 255169:256316 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) BUG=571691 TBR=hans ========== to ========== roll clang 255169:256316 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) Note that this brings in a libc++ regression on Mac [1]: some of the symbols that are hidden symbols in the system libc++ in OS X 10.8 are marked as "inline" in the headers shipped with this compiler -- this means that binaries produced by this compiler might not run on OS X 10.8 if these calls don't get inlined (or, if the 10.8 SDK is used, they won't link). That's ok for us though because production builds on OS X statically link a newer libc++ with these symbols exported, the iOS bots run newer OS X versions than 10.8, and so do the Mac bots that do component builds (which use the system libc++) or asan builds. And soon we'll roll in r257193 which fixes this again. 1: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160104/146428.html BUG=571691 TBR=hans ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539373005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539373005/180001
Message was sent while issue was closed.
Description was changed from ========== roll clang 255169:256316 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) Note that this brings in a libc++ regression on Mac [1]: some of the symbols that are hidden symbols in the system libc++ in OS X 10.8 are marked as "inline" in the headers shipped with this compiler -- this means that binaries produced by this compiler might not run on OS X 10.8 if these calls don't get inlined (or, if the 10.8 SDK is used, they won't link). That's ok for us though because production builds on OS X statically link a newer libc++ with these symbols exported, the iOS bots run newer OS X versions than 10.8, and so do the Mac bots that do component builds (which use the system libc++) or asan builds. And soon we'll roll in r257193 which fixes this again. 1: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160104/146428.html BUG=571691 TBR=hans ========== to ========== roll clang 255169:256316 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) Note that this brings in a libc++ regression on Mac [1]: some of the symbols that are hidden symbols in the system libc++ in OS X 10.8 are marked as "inline" in the headers shipped with this compiler -- this means that binaries produced by this compiler might not run on OS X 10.8 if these calls don't get inlined (or, if the 10.8 SDK is used, they won't link). That's ok for us though because production builds on OS X statically link a newer libc++ with these symbols exported, the iOS bots run newer OS X versions than 10.8, and so do the Mac bots that do component builds (which use the system libc++) or asan builds. And soon we'll roll in r257193 which fixes this again. 1: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160104/146428.html BUG=571691 TBR=hans ==========
Message was sent while issue was closed.
Committed patchset #10 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== roll clang 255169:256316 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) Note that this brings in a libc++ regression on Mac [1]: some of the symbols that are hidden symbols in the system libc++ in OS X 10.8 are marked as "inline" in the headers shipped with this compiler -- this means that binaries produced by this compiler might not run on OS X 10.8 if these calls don't get inlined (or, if the 10.8 SDK is used, they won't link). That's ok for us though because production builds on OS X statically link a newer libc++ with these symbols exported, the iOS bots run newer OS X versions than 10.8, and so do the Mac bots that do component builds (which use the system libc++) or asan builds. And soon we'll roll in r257193 which fixes this again. 1: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160104/146428.html BUG=571691 TBR=hans ========== to ========== roll clang 255169:256316 New: * /W4 in clang-cl enables -Wextra warnings * fix for link.exe /incremental build flakes * /Brepro suppresses timestamps for deterministic builds (doesn't work with link.exe /incremental) Note that this brings in a libc++ regression on Mac [1]: some of the symbols that are hidden symbols in the system libc++ in OS X 10.8 are marked as "inline" in the headers shipped with this compiler -- this means that binaries produced by this compiler might not run on OS X 10.8 if these calls don't get inlined (or, if the 10.8 SDK is used, they won't link). That's ok for us though because production builds on OS X statically link a newer libc++ with these symbols exported, the iOS bots run newer OS X versions than 10.8, and so do the Mac bots that do component builds (which use the system libc++) or asan builds. And soon we'll roll in r257193 which fixes this again. 1: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160104/146428.html BUG=571691 TBR=hans Committed: https://crrev.com/483df9304bb678dd50b435a41c063a3aed96d10f Cr-Commit-Position: refs/heads/master@{#368796} ==========
Message was sent while issue was closed.
Patchset 10 (id:??) landed as https://crrev.com/483df9304bb678dd50b435a41c063a3aed96d10f Cr-Commit-Position: refs/heads/master@{#368796}
Message was sent while issue was closed.
A revert of this CL (patchset #10 id:180001) has been created in https://codereview.chromium.org/1575393003/ by jchaffraix@chromium.org. The reason for reverting is: The Mac OS 10.7 Debug Blink bot is hitting the regression mentioned in the CL while running several Blink unittests: dyld: lazy symbol binding failed: Symbol not found: __ZNSt3__114basic_iostreamIcNS_11char_traitsIcEEEC2EPNS_15basic_streambufIcS2_EE Referenced from: /Volumes/data/b/swarm_slave/work/isolated/runImpjEb/third_party/WebKit/Source/wtf/../../../../out/Debug/wtf_unittests Expected in: /usr/lib/libc++.1.dylib dyld: Symbol not found: __ZNSt3__114basic_iostreamIcNS_11char_traitsIcEEEC2EPNS_15basic_streambufIcS2_EE Referenced from: /Volumes/data/b/swarm_slave/work/isolated/runImpjEb/third_party/WebKit/Source/wtf/../../../../out/Debug/wtf_unittests Expected in: /usr/lib/libc++.1.dylib Full output: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28d.... |
