Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15786003: WIP don't review: Implement Future (Closed)

Created:
7 years, 7 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 6 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, kinuko+watch, yhirano
Visibility:
Public.

Description

Implement Future Spec: http://dom.spec.whatwg.org/#futures BUG=243345

Patch Set 1 #

Patch Set 2 : Initial working snapshot #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1597 lines, -144 lines) Patch
A LayoutTests/fast/js/Future-accept.html View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Future-accept-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/js/Future-already-resolved.html View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Future-already-resolved-expected.txt View 1 2 1 chunk +1 line, -2 lines 0 comments Download
A LayoutTests/fast/js/Future-chain.html View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Future-chain-expected.txt View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
A LayoutTests/fast/js/Future-done.html View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Future-done-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A LayoutTests/fast/js/Future-exception.html View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Future-exception-expected.txt View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
A LayoutTests/fast/js/Future-init-throws.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Future-init-throws-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A LayoutTests/fast/js/Future-reject.html View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Future-reject-expected.txt View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
A LayoutTests/fast/js/Future-resolve.html View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Future-resolve-combination.html View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Future-resolve-combination-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + LayoutTests/fast/js/Future-resolve-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A LayoutTests/fast/js/Future-simple.html View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Future-simple-accept-async.html View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Future-simple-accept-async-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/js/Future-simple-accept-inside-callback.html View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Future-simple-accept-inside-callback-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/js/Future-simple-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A LayoutTests/fast/js/Future-then-without-callbacks.html View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Future-then-without-callbacks-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/bindings.gypi View 1 3 chunks +6 lines, -0 lines 0 comments Download
A + Source/bindings/v8/V8AnyCallback.h View 1 3 chunks +25 lines, -16 lines 0 comments Download
A Source/bindings/v8/V8AnyCallback.cpp View 1 1 chunk +109 lines, -0 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 2 chunks +9 lines, -0 lines 0 comments Download
A + Source/bindings/v8/V8FutureInit.h View 3 chunks +26 lines, -16 lines 0 comments Download
A + Source/bindings/v8/V8FutureInit.cpp View 1 3 chunks +47 lines, -28 lines 0 comments Download
A Source/bindings/v8/custom/V8FutureCustom.cpp View 1 1 chunk +145 lines, -0 lines 0 comments Download
A Source/bindings/v8/custom/V8FutureResolverCustom.cpp View 1 2 1 chunk +112 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 3 chunks +8 lines, -0 lines 0 comments Download
A + Source/core/dom/AnyCallback.h View 1 1 chunk +14 lines, -15 lines 0 comments Download
A Source/core/dom/Future.h View 1 1 chunk +137 lines, -0 lines 1 comment Download
A Source/core/dom/Future.cpp View 1 1 chunk +300 lines, -0 lines 0 comments Download
A + Source/core/dom/Future.idl View 1 chunk +13 lines, -4 lines 0 comments Download
A + Source/core/dom/FutureInit.h View 1 chunk +17 lines, -15 lines 0 comments Download
A + Source/core/dom/FutureResolver.h View 1 1 chunk +28 lines, -13 lines 0 comments Download
A Source/core/dom/FutureResolver.cpp View 1 1 chunk +124 lines, -0 lines 0 comments Download
A + Source/core/dom/FutureResolver.idl View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
https://codereview.chromium.org/15786003/diff/5001/Source/core/dom/Future.h File Source/core/dom/Future.h (right): https://codereview.chromium.org/15786003/diff/5001/Source/core/dom/Future.h#newcode129 Source/core/dom/Future.h:129: ScriptValue m_result; We should talk more about the general ...
7 years, 7 months ago (2013-05-23 17:56:47 UTC) #1
Peter Beverloo
I imagine this is still a draft? While we don't have WebKit-style ChangeLogs anymore, this ...
7 years, 7 months ago (2013-05-23 22:39:33 UTC) #2
tyoshino (SeeGerritForStatus)
yes. wip cl just for discussion. renamed subject not to confuse people.
7 years, 7 months ago (2013-05-24 02:29:45 UTC) #3
tyoshino (SeeGerritForStatus)
7 years, 6 months ago (2013-06-19 16:52:14 UTC) #4 
Visitors, please see crbug.com/243345. This CL is abandoned and Futures
(Promises) are now implemented based on new approach.

Powered by Google App Engine
This is Rietveld 408576698