Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1578473002: Pass application ids via AcceptConnection & ConnectToApplication callback. (Closed)

Created:
4 years, 11 months ago by Ben Goodger (Google)
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass application ids via AcceptConnection & ConnectToApplication callback. R=sky@chromium.org BUG= Committed: https://crrev.com/c1743467cdf568e940554b076c264b325185f341 Cr-Commit-Position: refs/heads/master@{#371833}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Total comments: 1

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -122 lines) Patch
M components/bitmap_uploader/bitmap_uploader.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M components/font_service/public/cpp/font_loader.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/media_factory.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M components/web_view/frame_connection.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -3 lines 0 comments Download
M components/web_view/frame_utils.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_app_connection_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M mash/task_viewer/task_viewer_application_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/application_instance.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/application_instance.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +19 lines, -20 lines 0 comments Download
M mojo/shell/application_manager.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_manager.cc View 1 2 3 4 5 6 7 chunks +11 lines, -7 lines 0 comments Download
M mojo/shell/application_manager_apptest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 8 chunks +27 lines, -18 lines 0 comments Download
M mojo/shell/application_manager_apptest_driver.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/application_manager_apptest_target.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_manager_apptests.mojom View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/package_manager/content_handler_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +13 lines, -9 lines 0 comments Download
M mojo/shell/package_manager/package_manager_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/application_connection.h View 1 2 3 4 5 6 1 chunk +16 lines, -7 lines 0 comments Download
M mojo/shell/public/cpp/application_impl.h View 1 2 3 4 5 6 3 chunks +6 lines, -1 line 0 comments Download
M mojo/shell/public/cpp/lib/application_impl.cc View 1 2 3 4 5 6 3 chunks +10 lines, -5 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_test_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +7 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/lib/service_registry.h View 1 2 3 4 5 6 3 chunks +9 lines, -5 lines 0 comments Download
M mojo/shell/public/cpp/lib/service_registry.cc View 1 2 3 4 5 6 5 chunks +25 lines, -11 lines 0 comments Download
M mojo/shell/public/interfaces/application.mojom View 1 2 3 4 5 6 7 8 2 chunks +6 lines, -1 line 0 comments Download
M mojo/shell/public/interfaces/application_manager.mojom View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/public/interfaces/shell.mojom View 1 2 3 4 5 6 2 chunks +4 lines, -5 lines 0 comments Download
M ui/views/mus/surface_binding.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 36 (19 generated)
Ben Goodger (Google)
4 years, 11 months ago (2016-01-12 20:08:25 UTC) #1
sky
LGTM https://codereview.chromium.org/1578473002/diff/140001/mojo/shell/public/interfaces/application.mojom File mojo/shell/public/interfaces/application.mojom (right): https://codereview.chromium.org/1578473002/diff/140001/mojo/shell/public/interfaces/application.mojom#newcode26 mojo/shell/public/interfaces/application.mojom:26: Initialize(Shell shell, string url, uint32 id); nit: document ...
4 years, 11 months ago (2016-01-12 20:57:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578473002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578473002/160001
4 years, 11 months ago (2016-01-12 22:32:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/7114) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 11 months ago (2016-01-12 22:50:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578473002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578473002/180001
4 years, 11 months ago (2016-01-12 23:12:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/35427)
4 years, 11 months ago (2016-01-12 23:30:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578473002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578473002/200001
4 years, 11 months ago (2016-01-13 00:58:24 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/35508)
4 years, 11 months ago (2016-01-13 01:23:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578473002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578473002/200001
4 years, 11 months ago (2016-01-13 04:17:37 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/7312)
4 years, 11 months ago (2016-01-13 04:35:08 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578473002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578473002/220001
4 years, 11 months ago (2016-01-13 20:25:24 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) mac_chromium_gn_rel on ...
4 years, 11 months ago (2016-01-13 23:39:13 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578473002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578473002/220001
4 years, 11 months ago (2016-01-26 22:03:41 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/122105) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-26 22:08:04 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578473002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578473002/240001
4 years, 11 months ago (2016-01-27 17:54:50 UTC) #33
commit-bot: I haz the power
Committed patchset #13 (id:240001)
4 years, 11 months ago (2016-01-27 19:05:18 UTC) #34
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 19:06:18 UTC) #36
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/c1743467cdf568e940554b076c264b325185f341
Cr-Commit-Position: refs/heads/master@{#371833}

Powered by Google App Engine
This is Rietveld 408576698