Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: mash/task_viewer/task_viewer_application_delegate.cc

Issue 1578473002: Pass application ids via AcceptConnection & ConnectToApplication callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | mojo/shell/application_instance.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mash/task_viewer/task_viewer_application_delegate.cc
diff --git a/mash/task_viewer/task_viewer_application_delegate.cc b/mash/task_viewer/task_viewer_application_delegate.cc
index 7a6aa4b1b667ff8d3e9aa3f41598b317a0a76ce7..48595fef2c1b91c37aa470ac54c0960d19d812c8 100644
--- a/mash/task_viewer/task_viewer_application_delegate.cc
+++ b/mash/task_viewer/task_viewer_application_delegate.cc
@@ -65,11 +65,11 @@ class TaskViewer : public views::WidgetDelegateView,
private:
struct ApplicationInfo {
- int id;
+ uint32_t id;
std::string url;
uint32_t pid;
- ApplicationInfo(int id, const std::string url, base::ProcessId pid)
+ ApplicationInfo(uint32_t id, const std::string url, base::ProcessId pid)
: id(id), url(url), pid(pid) {}
};
@@ -145,7 +145,7 @@ class TaskViewer : public views::WidgetDelegateView,
application->pid)));
observer_->OnItemsAdded(static_cast<int>(applications_.size()), 1);
}
- void ApplicationInstanceDestroyed(int32_t id) override {
+ void ApplicationInstanceDestroyed(uint32_t id) override {
for (auto it = applications_.begin(); it != applications_.end(); ++it) {
if ((*it)->id == id) {
observer_->OnItemsRemoved(
@@ -156,7 +156,7 @@ class TaskViewer : public views::WidgetDelegateView,
}
NOTREACHED();
}
- void ApplicationPIDAvailable(int id, uint32_t pid) override {
+ void ApplicationPIDAvailable(uint32_t id, uint32_t pid) override {
for (auto it = applications_.begin(); it != applications_.end(); ++it) {
if ((*it)->id == id) {
(*it)->pid = pid;
@@ -167,7 +167,7 @@ class TaskViewer : public views::WidgetDelegateView,
}
}
- bool ContainsId(int id) const {
+ bool ContainsId(uint32_t id) const {
for (auto& it : applications_) {
if (it->id == id)
return true;
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | mojo/shell/application_instance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698