Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1578453003: Enable DirectComposition by default. (Closed)

Created:
4 years, 11 months ago by jbauman
Modified:
4 years, 11 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable DirectComposition by default. Chrome will now use DirectComposition where supported (Win8+ with d3d11 rendering). --disable-direct-composition can be specified to disable it, and a disable_direct_composition driver bug workaround type has been added. BUG=524838 Committed: https://crrev.com/88b36341a5868273eeeb08d42047721e00f495d6 Cr-Commit-Position: refs/heads/master@{#369289}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_switches.cc View 2 chunks +12 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
jbauman
4 years, 11 months ago (2016-01-12 20:48:11 UTC) #3
Ken Russell (switch to Gerrit)
If you think this is ready to ship, LGTM.
4 years, 11 months ago (2016-01-12 21:16:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578453003/20001
4 years, 11 months ago (2016-01-13 20:08:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-13 23:28:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578453003/20001
4 years, 11 months ago (2016-01-14 00:26:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 02:39:52 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/88b36341a5868273eeeb08d42047721e00f495d6 Cr-Commit-Position: refs/heads/master@{#369289}
4 years, 11 months ago (2016-01-14 02:42:10 UTC) #14
Zhenyao Mo
4 years, 11 months ago (2016-01-14 18:38:46 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1573913009/ by zmo@chromium.org.

The reason for reverting is: This seems to break gles2_conform_test on win8
bots.

Powered by Google App Engine
This is Rietveld 408576698