chrome/BUILD.gn - Issue 1578433002: Implementation of newly designed sign in related histograms for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 1578433002: Implementation of newly designed sign in related histograms for Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use auto-generated enum Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkSigninActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index cefb2dd621170f6eb6cc7507c2b05b67f3526531..819b661e6b07c4f57d955930e5fbe406770beaa7 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -942,6 +942,13 @@ if (is_android) {

]

}

+ # GYP: //chrome/chrome.gyp:signin_metrics_enum_java

+ java_cpp_enum("signin_metrics_enum_javagen") {

nyquist 2016/01/26 23:09:37 Do you need to depend on this in chrome/android/BU

gogerald1 2016/01/27 16:50:39 Done.

+ sources = [

+ "../components/signin/core/browser/signin_metrics.h",

nyquist 2016/01/26 23:09:37 It's a little bit odd to me that this does not liv

gogerald1 2016/01/27 16:50:39 Yes, I guess the reason is the generated enums are

+ ]

+ }

# GYP: //chrome/chrome.gyp:page_info_connection_type_java

java_cpp_enum("page_info_connection_type_javagen") {

sources = [