Implementation of newly designed sign in related histograms for Android

chrome/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/features.gni")
 import("//build/config/locales.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/ui.gni")
@@ skipping 924 matching lines @@
     ]
   }
 
   # GYP: //chrome/chrome.gyp:content_settings_type_java
   java_cpp_enum("content_settings_type_javagen") {
     sources = [
       "../components/content_settings/core/common/content_settings_types.h",
     ]
   }
 
+  # GYP: //chrome/chrome.gyp:signin_metrics_enum_java
+  java_cpp_enum("signin_metrics_enum_javagen") {

[nyquist, 2016/01/26 23:09:37]

Do you need to depend on this in chrome/android/BUILD.gn as well?

[gogerald1, 2016/01/27 16:50:39]

Done.

+    sources = [
+      "../components/signin/core/browser/signin_metrics.h",

[nyquist, 2016/01/26 23:09:37]

It's a little bit odd to me that this does not live i n//components/signing, but
I guess that's fine since others are doing the same thing.

[gogerald1, 2016/01/27 16:50:39]

Yes, I guess the reason is the generated enums are used in org.chromium.chrome.*
but not org.chromium.components.*.

+    ]
+  }
+
   # GYP: //chrome/chrome.gyp:page_info_connection_type_java
   java_cpp_enum("page_info_connection_type_javagen") {
     sources = [
       "browser/ui/android/website_settings_popup_android.h",
     ]
   }
 
   # Some android targets still depend on --gc-sections to link.
   # TODO: remove --gc-sections for Debug builds (crbug.com/159847).
   config("gc_sections") {
@@ skipping 111 matching lines @@
       "//chrome/app/theme/$branding_path_component/product_logo_48.png",
       "//chrome/tools/build/linux/chrome-wrapper",
       "//third_party/xdg-utils/scripts/xdg-mime",
       "//third_party/xdg-utils/scripts/xdg-settings",
     ]
     outputs = [
       "$root_out_dir/{{source_file_part}}",
     ]
   }
 }