third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp - Issue 1578263006: Add metrics for usage of permission features from iframes in blink

Unified Diff: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

Issue 1578263006: Add metrics for usage of permission features from iframes in blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/UseCounter.cpp ('K') | « third_party/WebKit/Source/modules/geolocation/Geolocation.cpp ('k') | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('j') | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

index 2ed43245c95c4e4b999096293a5b150fe6fba48f..dd2a4955dc7497730f1c497cf88c687a1111d2ea 100644

--- a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

@@ -125,6 +125,7 @@ bool UserMediaRequest::isSecureContextUse(String& errorMessage)

if (document->isSecureContext(errorMessage)) {

UseCounter::count(document->frame(), UseCounter::GetUserMediaSecureOrigin);

+ UseCounter::countCrossOriginIframe(*document, UseCounter::GetUserMediaSecureOriginIframe);

mlamouri (slow - plz ping) 2016/01/19 17:54:48 Should you add a GetUserMediaInsecureOriginIframe

raymes 2016/01/20 00:13:12 It's not very useful (for us at least) because it

mlamouri (slow - plz ping) 2016/01/21 13:53:18 You do it for geolocation. I think you should do i

raymes 2016/01/27 06:57:51 Done.

OriginsUsingFeatures::countAnyWorld(*document, OriginsUsingFeatures::Feature::GetUserMediaSecureOrigin);

return true;

}