third_party/WebKit/Source/modules/geolocation/Geolocation.cpp - Issue 1578263006: Add metrics for usage of permission features from iframes in blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 1578263006: Add metrics for usage of permission features from iframes in blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/UseCounter.cpp ('K') | « third_party/WebKit/Source/core/frame/UseCounter.cpp ('k') | third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp » ('j') | third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

index a4c056a99843c9741a33770f3db31497e4837b69..1733b084ccb5571c6b618609d7006ffc8d34cd1c 100644

--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

@@ -157,8 +157,10 @@ void Geolocation::recordOriginTypeAccess() const

String insecureOriginMsg;

if (document->isSecureContext(insecureOriginMsg)) {

UseCounter::count(document, UseCounter::GeolocationSecureOrigin);

+ UseCounter::countCrossOriginIframe(*document, UseCounter::GeolocationSecureOriginIframe);

} else {

UseCounter::countDeprecation(document, UseCounter::GeolocationInsecureOrigin);

+ UseCounter::countCrossOriginIframe(*document, UseCounter::GeolocationInsecureOriginIframe);

OriginsUsingFeatures::countAnyWorld(*document, OriginsUsingFeatures::Feature::GeolocationInsecureOrigin);

}