Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1578253004: Fix a typo in WebrtcVideoStream::Start() which causes the host to crash. (Closed)

Created:
4 years, 11 months ago by Sergey Ulanov
Modified:
4 years, 11 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a typo in WebrtcVideoStream::Start() which causes the host to crash. When landing https://codereview.chromium.org/1571543002 a last-minute change was made to address review comment in webrtc_video_stream.cc and the change wasn't properly validated. Committed: https://crrev.com/067b65d4448b7a28ebf7b3a7d96168a97fa4c21a Cr-Commit-Position: refs/heads/master@{#369080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/protocol/webrtc_video_stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Sergey Ulanov
4 years, 11 months ago (2016-01-12 21:23:10 UTC) #3
kelvinp
lgtm
4 years, 11 months ago (2016-01-13 01:17:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578253004/1
4 years, 11 months ago (2016-01-13 01:27:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 02:26:35 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 02:27:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/067b65d4448b7a28ebf7b3a7d96168a97fa4c21a
Cr-Commit-Position: refs/heads/master@{#369080}

Powered by Google App Engine
This is Rietveld 408576698