Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1578143002:
Thread up UseCounters for a few new metrics from V8 (Closed)
|
Created:
4 years, 11 months ago by Dan Ehrenberg Modified:
4 years, 11 months ago CC:
adamk, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionThread up UseCounters for a few new metrics from V8
The metrics were added in the V8 patch reviewed at
https://codereview.chromium.org/1558113002
They measure
- Each of the three deprecated Promise functions
- Two nonstandard pieces of Intl functionality
- Accesses of the RegExp.prototype.unicode getter on the prototype
BUG=v8:3785, v8:3238, v8:4633
Committed: https://crrev.com/1442df781281d066c3d7e0c479364dad1ad43900
Cr-Commit-Position: refs/heads/master@{#371473}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : Rebase (and propagate extra counters to histograms.xml) #
Messages
Total messages: 30 (15 generated)
Description was changed from ========== Thread up UseCounters for a few new metrics from V8 The metrics were added in the V8 patch reviewed at https://codereview.chromium.org/1558113002 They measure - Each of the three deprecated Promise functions - Two nonstandard pieces of Intl functionality - Accesses of the RegExp.prototype.unicode getter on the prototype BUG=v8:3785,v8:3238,v8:4633 LOG=N ========== to ========== Thread up UseCounters for a few new metrics from V8 The metrics were added in the V8 patch reviewed at https://codereview.chromium.org/1558113002 They measure - Each of the three deprecated Promise functions - Two nonstandard pieces of Intl functionality - Accesses of the RegExp.prototype.unicode getter on the prototype BUG=v8:3785,v8:3238,v8:4633 ==========
littledan@chromium.org changed reviewers: + ishell@chromium.org, japhet@chromium.org
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578143002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by littledan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578143002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by littledan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org Link to the patchset: https://codereview.chromium.org/1578143002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578143002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
bindings LGTM
The CQ bit was checked by littledan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578143002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
ishell@chromium.org changed reviewers: + isherman@chromium.org
Ilya, PTAL histograms.xml change.
histograms.xml lgtm
The CQ bit was checked by littledan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, japhet@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/1578143002/#ps40001 (title: "Rebase (and propagate extra counters to histograms.xml)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578143002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Thread up UseCounters for a few new metrics from V8 The metrics were added in the V8 patch reviewed at https://codereview.chromium.org/1558113002 They measure - Each of the three deprecated Promise functions - Two nonstandard pieces of Intl functionality - Accesses of the RegExp.prototype.unicode getter on the prototype BUG=v8:3785,v8:3238,v8:4633 ========== to ========== Thread up UseCounters for a few new metrics from V8 The metrics were added in the V8 patch reviewed at https://codereview.chromium.org/1558113002 They measure - Each of the three deprecated Promise functions - Two nonstandard pieces of Intl functionality - Accesses of the RegExp.prototype.unicode getter on the prototype BUG=v8:3785,v8:3238,v8:4633 Committed: https://crrev.com/1442df781281d066c3d7e0c479364dad1ad43900 Cr-Commit-Position: refs/heads/master@{#371473} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1442df781281d066c3d7e0c479364dad1ad43900 Cr-Commit-Position: refs/heads/master@{#371473} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
