Add UseCounters for various standards-related code paths

Add UseCounters for various standards-related code paths

- Each of the three deprecated Promise functions
- Two nonstandard pieces of Intl functionality
- Accesses of the RegExp.prototype.unicode getter on the prototype

BUG=v8:3785, v8:3238, v8:4633
LOG=N
R=adamk
TBR=hpayer

Committed: https://crrev.com/09685b5b00b3418945dca895193b9d81e2e0cdee
Cr-Commit-Position: refs/heads/master@{#33142}

[Dan Ehrenberg, 2016-01-05 06:12:56]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-05 06:13:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558113002/20001

[commit-bot: I haz the power, 2016-01-05 06:43:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 06:43:32]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-01-05 19:10:10]

https://codereview.chromium.org/1558113002/diff/20001/src/i18n.cc
File src/i18n.cc (right):

https://codereview.chromium.org/1558113002/diff/20001/src/i18n.cc#newcode148
src/i18n.cc:148: resolved, handle(isolate->heap()->pattern_symbol(), isolate),
"factory->pattern_symbol()" will give you a handle directly.

https://codereview.chromium.org/1558113002/diff/20001/src/i18n.cc#newcode370
src/i18n.cc:370: resolved, handle(isolate->heap()->pattern_symbol(), isolate),
ditto

https://codereview.chromium.org/1558113002/diff/20001/src/js/harmony-unicode-...
File src/js/harmony-unicode-regexps.js (right):

https://codereview.chromium.org/1558113002/diff/20001/src/js/harmony-unicode-...
src/js/harmony-unicode-regexps.js:18: const kRegExpPrototypeUnicodeGetter = 11;
Hmm, it seems like only one other place (harmony-regexp.js) uses const. I'd
prefer to follow the rest of the natives and use a macro for this for now.

https://codereview.chromium.org/1558113002/diff/20001/src/js/i18n.js
File src/js/i18n.js (right):

https://codereview.chromium.org/1558113002/diff/20001/src/js/i18n.js#newcode1571
src/js/i18n.js:1571: pattern: {get() {
Don't you want a setter too, since the old property was writable?

https://codereview.chromium.org/1558113002/diff/20001/src/js/promise.js
File src/js/promise.js (right):

https://codereview.chromium.org/1558113002/diff/20001/src/js/promise.js#newco...
src/js/promise.js:29: const kPromiseDefer = 19;
Same for theses consts. I can imagine doing a cleanup later where we move
constants from macros into the source file.

I'm open to arguments for why we should diverge here.

https://codereview.chromium.org/1558113002/diff/20001/src/js/promise.js#newco...
src/js/promise.js:244: function PromiseDeferred() {
Could this be renamed "PromiseDefer" for clarity? It looks like it doesn't
really have callers any more.

https://codereview.chromium.org/1558113002/diff/20001/src/js/promise.js#newco...
src/js/promise.js:249: function PromiseResolved(x) {
Same here, clarity. The two lines where this function has different names are
surprising.

[Dan Ehrenberg, 2016-01-06 03:20:55]

https://codereview.chromium.org/1558113002/diff/20001/src/i18n.cc
File src/i18n.cc (right):

https://codereview.chromium.org/1558113002/diff/20001/src/i18n.cc#newcode148
src/i18n.cc:148: resolved, handle(isolate->heap()->pattern_symbol(), isolate),
On 2016/01/05 at 19:10:09, adamk wrote:
> "factory->pattern_symbol()" will give you a handle directly.

Done

https://codereview.chromium.org/1558113002/diff/20001/src/i18n.cc#newcode370
src/i18n.cc:370: resolved, handle(isolate->heap()->pattern_symbol(), isolate),
On 2016/01/05 at 19:10:09, adamk wrote:
> ditto

ditto

https://codereview.chromium.org/1558113002/diff/20001/src/js/harmony-unicode-...
File src/js/harmony-unicode-regexps.js (right):

https://codereview.chromium.org/1558113002/diff/20001/src/js/harmony-unicode-...
src/js/harmony-unicode-regexps.js:18: const kRegExpPrototypeUnicodeGetter = 11;
On 2016/01/05 at 19:10:09, adamk wrote:
> Hmm, it seems like only one other place (harmony-regexp.js) uses const. I'd
prefer to follow the rest of the natives and use a macro for this for now.

Alright, used macros instead.

https://codereview.chromium.org/1558113002/diff/20001/src/js/i18n.js
File src/js/i18n.js (right):

https://codereview.chromium.org/1558113002/diff/20001/src/js/i18n.js#newcode1571
src/js/i18n.js:1571: pattern: {get() {
On 2016/01/05 at 19:10:09, adamk wrote:
> Don't you want a setter too, since the old property was writable?

Oh, good point. Done.

https://codereview.chromium.org/1558113002/diff/20001/src/js/promise.js
File src/js/promise.js (right):

https://codereview.chromium.org/1558113002/diff/20001/src/js/promise.js#newco...
src/js/promise.js:29: const kPromiseDefer = 19;
On 2016/01/05 at 19:10:09, adamk wrote:
> Same for theses consts. I can imagine doing a cleanup later where we move
constants from macros into the source file.
> 
> I'm open to arguments for why we should diverge here.

I don't like macros! But this patch isn't the forum for that kind of argument.
Switched to using macros.

https://codereview.chromium.org/1558113002/diff/20001/src/js/promise.js#newco...
src/js/promise.js:244: function PromiseDeferred() {
On 2016/01/05 at 19:10:09, adamk wrote:
> Could this be renamed "PromiseDefer" for clarity? It looks like it doesn't
really have callers any more.

Agreed that this is confusing. I plan to do this and other cleanups that Camillo
recommended once the current batch of Promise patches goes in (chiefly Caitlin's
patches).

https://codereview.chromium.org/1558113002/diff/20001/src/js/promise.js#newco...
src/js/promise.js:249: function PromiseResolved(x) {
On 2016/01/05 at 19:10:09, adamk wrote:
> Same here, clarity. The two lines where this function has different names are
surprising.

Ditto.

[adamk, 2016-01-06 18:53:05]

lgtm

[Dan Ehrenberg, 2016-01-06 18:54:56]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-01-06 18:55:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558113002/60001

[commit-bot: I haz the power, 2016-01-06 18:57:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 18:57:35]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9489)

[Dan Ehrenberg, 2016-01-06 19:27:34]

Description was changed from

==========
Add UseCounters for various standards-related code paths

- Each of the three deprecated Promise functions
- Two nonstandard pieces of Intl functionality
- Accesses of the RegExp.prototype.unicode getter on the prototype

BUG=v8:3785,v8:3238,v8:4633
LOG=N
R=adamk
==========

to

==========
Add UseCounters for various standards-related code paths

- Each of the three deprecated Promise functions
- Two nonstandard pieces of Intl functionality
- Accesses of the RegExp.prototype.unicode getter on the prototype

BUG=v8:3785,v8:3238,v8:4633
LOG=N
R=adamk
TBR=hpayer
==========

[Dan Ehrenberg, 2016-01-06 19:27:36]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-01-06 19:27:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558113002/60001

[commit-bot: I haz the power, 2016-01-06 19:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 19:40:40]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12089)

[Dan Ehrenberg, 2016-01-06 23:27:55]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-01-06 23:27:55]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1558113002/#ps80001
(title: "Fix accidental redefinition")

[commit-bot: I haz the power, 2016-01-06 23:28:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558113002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558113002/80001

[commit-bot: I haz the power, 2016-01-07 00:12:33]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-07 00:13:09]

Description was changed from

==========
Add UseCounters for various standards-related code paths

- Each of the three deprecated Promise functions
- Two nonstandard pieces of Intl functionality
- Accesses of the RegExp.prototype.unicode getter on the prototype

BUG=v8:3785,v8:3238,v8:4633
LOG=N
R=adamk
TBR=hpayer
==========

to

==========
Add UseCounters for various standards-related code paths

- Each of the three deprecated Promise functions
- Two nonstandard pieces of Intl functionality
- Accesses of the RegExp.prototype.unicode getter on the prototype

BUG=v8:3785,v8:3238,v8:4633
LOG=N
R=adamk
TBR=hpayer

Committed: https://crrev.com/09685b5b00b3418945dca895193b9d81e2e0cdee
Cr-Commit-Position: refs/heads/master@{#33142}
==========

[commit-bot: I haz the power, 2016-01-07 00:13:10]

Patchset 5 (id:??) landed as
https://crrev.com/09685b5b00b3418945dca895193b9d81e2e0cdee
Cr-Commit-Position: refs/heads/master@{#33142}