Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 157813010: Revert of Update of change event for input type number (https://codereview.chromium.org/128133002/) (Closed)

Created:
6 years, 10 months ago by tkent
Modified:
6 years, 10 months ago
Reviewers:
Habib Virji, keishi
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert of Update of change event for input type number (https://codereview.chromium.org/128133002/) Reason for revert: INPUT element dispatches extra events. Original issue's description: > Do not dispatch 'change' events during pressing spin buttons for input[type=number]. > > TextFieldInputType sends change event for its derived class. Change is > done for DispatchInputAndChangeEvent to behave similar to > DispatchChangeEvent. > DispatchChangeEvent is generated by Range, Radio, File and Checkbox > input type. > DispatchInputAndChangeEvent is generated by inputtype for step up and > down, BaseChooser/BaseMultipleFieldsDateandTime also generates > DispatchInputAndChangeEvent. > Since it is different set of inputs that generate DispatchChange and > DispatchInputAndChange, both are kept but behavior is changed; this > allows spin button to handle mouseup event. > Keyboard events are also handled for spin button. > > R=tkent > BUG=155747 > TEST=automated > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165300 TBR=keishi@chromium.org,habib.virji@samsung.com NOTREECHECKS=true NOTRY=true BUG=155747 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166983

Patch Set 1 #

Messages

Total messages: 1 (0 generated)
tkent
6 years, 10 months ago (2014-02-12 08:02:01 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r166983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698