Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Unified Diff: apps/shell_window.h

Issue 157813007: Remove Profile dependency from apps::ShellWindow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: apps/shell_window.h
diff --git a/apps/shell_window.h b/apps/shell_window.h
index 8be7a59581f692b8f4c94f3731f0a0877c525319..2901376bc9c8d16dbc48f1e186af1c508969721d 100644
--- a/apps/shell_window.h
+++ b/apps/shell_window.h
@@ -21,7 +21,6 @@
#include "ui/gfx/rect.h"
class GURL;
-class Profile;
class SkRegion;
namespace base {
@@ -29,6 +28,7 @@ class DictionaryValue;
}
namespace content {
+class BrowserContext;
class WebContents;
}
@@ -58,7 +58,8 @@ class ShellWindowContents {
virtual ~ShellWindowContents() {}
// Called to initialize the WebContents, before the app window is created.
- virtual void Initialize(Profile* profile, const GURL& url) = 0;
+ virtual void Initialize(content::BrowserContext* context,
+ const GURL& url) = 0;
// Called to load the contents, after the app window is created.
virtual void LoadContents(int32 creator_process_id) = 0;
@@ -201,10 +202,10 @@ class ShellWindow : public content::NotificationObserver,
// Link handling.
virtual content::WebContents* OpenURLFromTab(
- Profile* profile,
+ content::BrowserContext* context,
content::WebContents* source,
const content::OpenURLParams& params) = 0;
- virtual void AddNewContents(Profile* profile,
+ virtual void AddNewContents(content::BrowserContext* context,
content::WebContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
@@ -239,7 +240,7 @@ class ShellWindow : public content::NotificationObserver,
// with a non-standard render interface (e.g. v1 apps using Ash Panels).
// Normally ShellWindow::Create should be used.
// The constructed shell window takes ownership of |delegate|.
- ShellWindow(Profile* profile,
+ ShellWindow(content::BrowserContext* context,
Delegate* delegate,
const extensions::Extension* extension);
@@ -260,7 +261,7 @@ class ShellWindow : public content::NotificationObserver,
return (window_type_ == WINDOW_TYPE_PANEL ||
window_type_ == WINDOW_TYPE_V1_PANEL);
}
- Profile* profile() const { return profile_; }
+ content::BrowserContext* browser_context() const { return browser_context_; }
const gfx::Image& app_icon() const { return app_icon_; }
const GURL& app_icon_url() const { return app_icon_url_; }
const gfx::Image& badge_icon() const { return badge_icon_; }
@@ -488,7 +489,10 @@ class ShellWindow : public content::NotificationObserver,
virtual void OnExtensionIconImageChanged(
extensions::IconImage* image) OVERRIDE;
- Profile* profile_; // weak pointer - owned by ProfileManager.
+ // The browser context with which this window is associated. ShellWindow does
+ // not own this object.
+ content::BrowserContext* browser_context_;
+
// weak pointer - owned by ExtensionService.
const extensions::Extension* extension_;
const std::string extension_id_;

Powered by Google App Engine
This is Rietveld 408576698