Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1578003004: Do not prompt and/or create copies when Android logins are filled into websites. (Closed)

Created:
4 years, 11 months ago by engedy
Modified:
4 years, 11 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Do not prompt and/or create copies when Android logins are filled into websites. Presently, when logins from Android apps are filled into the corresponding websites and are used for a successful login, the user is prompted to save a new credential, and ultimately a copy of the credential, keyed by the web site, gets saved to the password store. This is a very confusing UX, and also results in duplicate logins being created. Later, these can lead to an out-of-date password stored for the Android app if the Web password is ever updated in the future. Instead, in this scenario, do not prompt at all, do not save any new credentials, but simply update the usage count of the existing Android credential in-place while leaving the other meta-attributes untouched. BUG=540609 TBR=vabr@chromium.org Review URL: https://codereview.chromium.org/1571813002 Cr-Commit-Position: refs/heads/master@{#368421} (cherry picked from commit 90098fdb2f7fe52185ec1bce37252e89942712ad) Committed: https://chromium.googlesource.com/chromium/src/+/8b349ff7c1b32ea1a71c15cd4abee11c4da46386

Patch Set 1 #

Patch Set 2 : Noop. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -18 lines) Patch
M components/password_manager/core/browser/password_form_manager.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 1 chunk +40 lines, -9 lines 0 comments Download
M components/password_manager/core/browser/password_manager_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (4 generated)
engedy
4 years, 11 months ago (2016-01-12 19:33:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8b349ff7c1b32ea1a71c15cd4abee11c4da46386.

Powered by Google App Engine
This is Rietveld 408576698