Do not prompt and/or create copies when Android logins are filled into websites.

Do not prompt and/or create copies when Android logins are filled into websites.

Presently, when logins from Android apps are filled into the corresponding websites and are used for a successful login, the user is prompted to save a new credential, and ultimately a copy of the credential, keyed by the web site, gets saved to the password store.

This is a very confusing UX, and also results in duplicate logins being created.  Later, these can lead to an out-of-date password stored for the Android app if the Web password is ever updated in the future.

Instead, in this scenario, do not prompt at all, do not save any new credentials, but simply update the usage count of the existing Android credential in-place while leaving the other meta-attributes untouched.

BUG=540609
Committed: https://crrev.com/90098fdb2f7fe52185ec1bce37252e89942712ad
Cr-Commit-Position: refs/heads/master@{#368421}

[engedy, 2016-01-08 17:48:11]

Description was changed from

==========
Do not prompt and/or create copies when Android logins are filled into websites.

Presently, when logins from Android apps are filled into the corresponding
websites and are used for a successful login, the user is prompted to save a new
credential, and ultimately a copy of the credential, keyed by the web site, gets
saved to the password store.

This is a very confusing UX, and also results in duplicate logins being created,
which, later, can lead to an out-of-date password stored for the Android app if
the Web password is ever updated in the future.

Instead, in this scenario, do not prompt at all, do not save any new
credentials, but simply update the usage count of the existing Android
credential in-place while leaving the other meta-attributes untouched.

BUG=540609
==========

to

==========
Do not prompt and/or create copies when Android logins are filled into websites.

Presently, when logins from Android apps are filled into the corresponding
websites and are used for a successful login, the user is prompted to save a new
credential, and ultimately a copy of the credential, keyed by the web site, gets
saved to the password store.

This is a very confusing UX, and also results in duplicate logins being created.
 Later, these can lead to an out-of-date password stored for the Android app if
the Web password is ever updated in the future.

Instead, in this scenario, do not prompt at all, do not save any new
credentials, but simply update the usage count of the existing Android
credential in-place while leaving the other meta-attributes untouched.

BUG=540609
==========

[engedy, 2016-01-08 17:48:11]

engedy@chromium.org changed reviewers:
+ vabr@chromium.org

[engedy, 2016-01-08 18:06:00]

Vaclav, please take a look.

[vabr (Chromium), 2016-01-08 18:15:44]

LGTM, thanks for the prompt fix of the issue.

Cheers,
Vaclav

https://codereview.chromium.org/1571813002/diff/20001/components/password_man...
File components/password_manager/core/browser/password_form_manager_unittest.cc
(right):

https://codereview.chromium.org/1571813002/diff/20001/components/password_man...
components/password_manager/core/browser/password_form_manager_unittest.cc:1349:
// incremented in place, as it were a regular credential for that website.
typo?
as it were -> as if it were

[engedy, 2016-01-08 19:30:05]

The CQ bit was checked by engedy@chromium.org

[engedy, 2016-01-08 19:30:06]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1571813002/#ps40001
(title: "Fix typo in comment.")

[commit-bot: I haz the power, 2016-01-08 19:30:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571813002/40001

[commit-bot: I haz the power, 2016-01-08 20:12:49]

Description was changed from

==========
Do not prompt and/or create copies when Android logins are filled into websites.

Presently, when logins from Android apps are filled into the corresponding
websites and are used for a successful login, the user is prompted to save a new
credential, and ultimately a copy of the credential, keyed by the web site, gets
saved to the password store.

This is a very confusing UX, and also results in duplicate logins being created.
 Later, these can lead to an out-of-date password stored for the Android app if
the Web password is ever updated in the future.

Instead, in this scenario, do not prompt at all, do not save any new
credentials, but simply update the usage count of the existing Android
credential in-place while leaving the other meta-attributes untouched.

BUG=540609
==========

to

==========
Do not prompt and/or create copies when Android logins are filled into websites.

Presently, when logins from Android apps are filled into the corresponding
websites and are used for a successful login, the user is prompted to save a new
credential, and ultimately a copy of the credential, keyed by the web site, gets
saved to the password store.

This is a very confusing UX, and also results in duplicate logins being created.
 Later, these can lead to an out-of-date password stored for the Android app if
the Web password is ever updated in the future.

Instead, in this scenario, do not prompt at all, do not save any new
credentials, but simply update the usage count of the existing Android
credential in-place while leaving the other meta-attributes untouched.

BUG=540609
==========

[commit-bot: I haz the power, 2016-01-08 20:12:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-08 20:13:41]

Description was changed from

==========
Do not prompt and/or create copies when Android logins are filled into websites.

Presently, when logins from Android apps are filled into the corresponding
websites and are used for a successful login, the user is prompted to save a new
credential, and ultimately a copy of the credential, keyed by the web site, gets
saved to the password store.

This is a very confusing UX, and also results in duplicate logins being created.
 Later, these can lead to an out-of-date password stored for the Android app if
the Web password is ever updated in the future.

Instead, in this scenario, do not prompt at all, do not save any new
credentials, but simply update the usage count of the existing Android
credential in-place while leaving the other meta-attributes untouched.

BUG=540609
==========

to

==========
Do not prompt and/or create copies when Android logins are filled into websites.

Presently, when logins from Android apps are filled into the corresponding
websites and are used for a successful login, the user is prompted to save a new
credential, and ultimately a copy of the credential, keyed by the web site, gets
saved to the password store.

This is a very confusing UX, and also results in duplicate logins being created.
 Later, these can lead to an out-of-date password stored for the Android app if
the Web password is ever updated in the future.

Instead, in this scenario, do not prompt at all, do not save any new
credentials, but simply update the usage count of the existing Android
credential in-place while leaving the other meta-attributes untouched.

BUG=540609

Committed: https://crrev.com/90098fdb2f7fe52185ec1bce37252e89942712ad
Cr-Commit-Position: refs/heads/master@{#368421}
==========

[commit-bot: I haz the power, 2016-01-08 20:13:42]

Patchset 3 (id:??) landed as
https://crrev.com/90098fdb2f7fe52185ec1bce37252e89942712ad
Cr-Commit-Position: refs/heads/master@{#368421}