Include full machine names when contacting a trooper

Include full machine names when contacting a trooper

I couldn't find any mention of this in our documentation
but it seems like a good reflex.

Committed: https://chromium.googlesource.com/infra/infra/+/9e1145dbec7a361866c245318111483eccd9387c

[Julien - ping for review, 2016-01-12 22:46:00]

jchaffraix@chromium.org changed reviewers:
+ friedman@chromium.org

[Julien - ping for review, 2016-01-12 22:46:00]

Elliott, per your request in
https://code.google.com/p/chromium/issues/detail?id=576782

[friedman1, 2016-01-12 22:48:16]

friedman@google.com changed reviewers:
+ friedman@google.com

[friedman1, 2016-01-12 22:48:16]

lgtm

Woah AWESOME!!! Thanks for doing this!

lgtm assuming the changes listed

https://codereview.chromium.org/1577973006/diff/1/doc/users/contacting_troope...
File doc/users/contacting_troopers.md (right):

https://codereview.chromium.org/1577973006/diff/1/doc/users/contacting_troope...
doc/users/contacting_troopers.md:25: Also make sure to include the machine full
name (e.g. build11-m1)
s/ full//

The full name would be build11-m1.golo.chromium.org

https://codereview.chromium.org/1577973006/diff/1/doc/users/contacting_troope...
doc/users/contacting_troopers.md:26: instead of the waterfall name (Builder:
Win).
s/instead of/as well as/

[Julien - ping for review, 2016-01-13 01:23:28]

The CQ bit was checked by jchaffraix@chromium.org

[Julien - ping for review, 2016-01-13 01:23:28]

Thanks Elliott!

https://codereview.chromium.org/1577973006/diff/1/doc/users/contacting_troope...
File doc/users/contacting_troopers.md (right):

https://codereview.chromium.org/1577973006/diff/1/doc/users/contacting_troope...
doc/users/contacting_troopers.md:25: Also make sure to include the machine full
name (e.g. build11-m1)
On 2016/01/12 at 22:48:16, friedman1 wrote:
> s/ full//
> The full name would be build11-m1.golo.chromium.org

Removed full as we don't want the FQDN indeed :)

https://codereview.chromium.org/1577973006/diff/1/doc/users/contacting_troope...
doc/users/contacting_troopers.md:26: instead of the waterfall name (Builder:
Win).
On 2016/01/12 at 22:48:16, friedman1 wrote:
> s/instead of/as well as/

Changed.

[Julien - ping for review, 2016-01-13 01:23:29]

The patchset sent to the CQ was uploaded after l-g-t-m from friedman@google.com
Link to the patchset: https://codereview.chromium.org/1577973006/#ps20001
(title: "Updated after Elliott's review.")

[commit-bot: I haz the power, 2016-01-13 01:23:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1577973006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1577973006/20001

[commit-bot: I haz the power, 2016-01-13 01:25:59]

Description was changed from

==========
Include full machine names when contacting a trooper

I couldn't find any mention of this in our documentation
but it seems like a good reflex.
==========

to

==========
Include full machine names when contacting a trooper

I couldn't find any mention of this in our documentation
but it seems like a good reflex.

Committed:
https://chromium.googlesource.com/infra/infra/+/9e1145dbec7a361866c2453181114...
==========

[commit-bot: I haz the power, 2016-01-13 01:26:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/9e1145dbec7a361866c2453181114...