Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: services/media/framework/models/lpcm_transform.h

Issue 1577953002: Motown in-proc streaming framework used to implement media services. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Sync, updates based on feedback, some functions declared const. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/media/framework/models/lpcm_transform.h
diff --git a/services/media/framework/models/lpcm_transform.h b/services/media/framework/models/lpcm_transform.h
new file mode 100644
index 0000000000000000000000000000000000000000..ad61f932f5b7f6ad8ba2d2c5a722b068cf8bb86b
--- /dev/null
+++ b/services/media/framework/models/lpcm_transform.h
@@ -0,0 +1,39 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MOJO_MEDIA_MODELS_LPCM_TRANSFORM_H_
+#define MOJO_MEDIA_MODELS_LPCM_TRANSFORM_H_
+
+#include <memory>
+
+#include "services/media/framework/models/lpcm_frames.h"
+#include "services/media/framework/stream_type.h"
+
+namespace mojo {
+namespace media {
+
+// Synchronous lpcm transform.
+class LpcmTransform {
+ public:
+ virtual ~LpcmTransform() {}
+
+ // Gets the input stream type.
+ virtual const LpcmStreamType& input_stream_type() const = 0;
+
+ // Gets the output stream type.
+ virtual const LpcmStreamType& output_stream_type() const = 0;
+
+ // Processes frames.
+ virtual void TransformFrames(
+ LpcmFrames* source,
jeffbrown 2016/02/02 05:35:47 const?
dalesat 2016/02/02 21:46:39 No, because the function calls source->Advance, re
+ LpcmFrames* dest,
+ bool mix) = 0;
jeffbrown 2016/02/02 05:35:47 Consider eliminating the bool and adding another m
dalesat 2016/02/02 21:46:39 Acknowledged.
+};
+
+typedef std::shared_ptr<LpcmTransform> LpcmTransformPtr;
+
+} // namespace media
+} // namespace mojo
+
+#endif // MOJO_MEDIA_MODELS_LPCM_TRANSFORM_H_

Powered by Google App Engine
This is Rietveld 408576698