Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: services/media/framework/models/lpcm_transform.h

Issue 1577953002: Motown in-proc streaming framework used to implement media services. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Sync, updates based on feedback, some functions declared const. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef MOJO_MEDIA_MODELS_LPCM_TRANSFORM_H_
6 #define MOJO_MEDIA_MODELS_LPCM_TRANSFORM_H_
7
8 #include <memory>
9
10 #include "services/media/framework/models/lpcm_frames.h"
11 #include "services/media/framework/stream_type.h"
12
13 namespace mojo {
14 namespace media {
15
16 // Synchronous lpcm transform.
17 class LpcmTransform {
18 public:
19 virtual ~LpcmTransform() {}
20
21 // Gets the input stream type.
22 virtual const LpcmStreamType& input_stream_type() const = 0;
23
24 // Gets the output stream type.
25 virtual const LpcmStreamType& output_stream_type() const = 0;
26
27 // Processes frames.
28 virtual void TransformFrames(
29 LpcmFrames* source,
jeffbrown 2016/02/02 05:35:47 const?
dalesat 2016/02/02 21:46:39 No, because the function calls source->Advance, re
30 LpcmFrames* dest,
31 bool mix) = 0;
jeffbrown 2016/02/02 05:35:47 Consider eliminating the bool and adding another m
dalesat 2016/02/02 21:46:39 Acknowledged.
32 };
33
34 typedef std::shared_ptr<LpcmTransform> LpcmTransformPtr;
35
36 } // namespace media
37 } // namespace mojo
38
39 #endif // MOJO_MEDIA_MODELS_LPCM_TRANSFORM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698