Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1577893002: Merge to XFA: Tidy up shading patterns (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Tidy up shading patterns Original Review URL: https://codereview.chromium.org/1570873005 . (cherry picked from commit a07804a3b16c10fa2011ef56d1dacefb7d21e4f6) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/492961df3011ccc25646eae12ac6e6dcfe7f26da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -80 lines) Patch
M core/include/fpdfapi/fpdf_resource.h View 2 chunks +18 lines, -24 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 3 chunks +26 lines, -44 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR
4 years, 11 months ago (2016-01-11 16:52:16 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 492961df3011ccc25646eae12ac6e6dcfe7f26da (presubmit successful).
4 years, 11 months ago (2016-01-11 17:11:14 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-11 20:20:57 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698