Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2626)

Unified Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 1577773002: WebRTC: Enable OpenH264 for WebRTC standalone bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Set the GN arguments properly Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/webrtc/chromium_config.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium/config.py
diff --git a/scripts/slave/recipe_modules/chromium/config.py b/scripts/slave/recipe_modules/chromium/config.py
index d467955af49d20f4a69d565d8d0e04789076dd33..1fb22f6258942b31b70770e7ee0fa45ebd98eb19 100644
--- a/scripts/slave/recipe_modules/chromium/config.py
+++ b/scripts/slave/recipe_modules/chromium/config.py
@@ -366,6 +366,12 @@ def proprietary_codecs(c, invert=False):
c.gyp_env.GYP_DEFINES['proprietary_codecs'] = int(not invert)
@config_ctx()
+def openh264(c):
hbos_chromium 2016/01/11 14:21:09 Hmm the name "openh264" might be misleading here s
kjellander_chromium 2016/01/12 10:11:45 Well, OpenH264 is not used at all in Chromium, as
+ ffmpeg_branding(c, branding='Chrome')
hbos_chromium 2016/01/11 14:21:09 (Any idea what happens if multiple defs are used a
kjellander_chromium 2016/01/12 10:11:45 Any latter will overwrite the previous, but it's u
+ c.gyp_env.GYP_DEFINES['use_openh264'] = 1
+ c.gyp_env.GYP_DEFINES['use_third_party_h264'] = 1
+
+@config_ctx()
def chrome_with_codecs(c):
ffmpeg_branding(c, branding='Chrome')
proprietary_codecs(c)
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/webrtc/chromium_config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698