Issue 15777007: Re-land: Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15777007: Re-land: Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice (Closed)

Created:
7 years, 6 months ago by rafaelw

Modified:
7 years, 6 months ago

Reviewers:
adamk, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Re-land: Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice Original issue: https://codereview.chromium.org/15331002/ Broke mozilla/js1_5/Array/regress-451483.js, which ends up attempting to call %IsObserved() on a non-object. IsObserved now checks for JSReceiver and returns false rather than crashing. R=adamk@chromium.org, rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14888

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+210 lines, -51 lines)			Patch
M	src/array.js	View	10 chunks	+143 lines, -34 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/mjsunit/harmony/object-observe.js	View	3 chunks	+64 lines, -16 lines	0 comments	Download

Total messages: 4 (0 generated)

adamk

7 years, 6 months ago (2013-05-29 17:26:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r14888 (presubmit successful).