src/runtime.cc - Issue 15777007: Re-land: Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 15777007: Re-land: Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 3e77584f8a2828bf0fdc872178879370e77b5443..5ac7840401d66dd4dd0e11ea001ff5424990cd4e 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -13360,7 +13360,9 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_HaveSameMap) {

RUNTIME_FUNCTION(MaybeObject*, Runtime_IsObserved) {

NoHandleAllocation ha(isolate);

ASSERT(args.length() == 1);

- CONVERT_ARG_CHECKED(JSReceiver, obj, 0);

+ if (!args[0]->IsJSReceiver()) return isolate->heap()->false_value();

+ JSReceiver* obj = JSReceiver::cast(args[0]);

if (obj->IsJSGlobalProxy()) {

Object* proto = obj->GetPrototype();

if (proto->IsNull()) return isolate->heap()->false_value();

« no previous file with comments | « src/array.js ('k') | test/mjsunit/harmony/object-observe.js » ('j') | no next file with comments »