Merge to XFA: Switch most min/max macros to std::min/max.

Merge to XFA: Switch most min/max macros to std::min/max.

Fix lint errors along the way.

R=tsepez@chromium.org
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1567343002 .

(cherry picked from commit 9adfbb0920a258e916003b1ee9515e97879db82a)

Committed: https://pdfium.googlesource.com/pdfium/+/375a86403b7fa8d17d7b142c270e2d8e33bb924f

[Lei Zhang, 2016-01-09 00:09:52]

See patch set 2.

[Tom Sepez, 2016-01-09 00:35:53]

I only reviewed the xfa/ files.

https://codereview.chromium.org/1577503002/diff/20001/xfa/src/fxbarcode/BC_Tw...
File xfa/src/fxbarcode/BC_TwoDimWriter.cpp (right):

https://codereview.chromium.org/1577503002/diff/20001/xfa/src/fxbarcode/BC_Tw...
xfa/src/fxbarcode/BC_TwoDimWriter.cpp:103:
std::max(static_cast<int32_t>(tempWidth * moduleHSize), tempWidth));
This code is troubling. moduleHSize is constrained to the [1.0..8.0], so
tempWidth * moduleHSize would always be larger, except if the value exceeds the
precision of int, in which case the cast back to int is undefined behaviour, and
certainly not an overflow check if they were intending one.

https://codereview.chromium.org/1577503002/diff/20001/xfa/src/fxbarcode/BC_Tw...
xfa/src/fxbarcode/BC_TwoDimWriter.cpp:105:
std::max(static_cast<int32_t>(tempHeight * moduleHSize), tempHeight));
in any event, I don't think the outer cast is required, youv'e got two int32_t
args to the min.

[Lei Zhang, 2016-01-09 00:43:00]

On 2016/01/09 00:35:53, Tom Sepez wrote:
> I only reviewed the xfa/ files.

There's xfa-only changes outside of xfa/

[Tom Sepez, 2016-01-09 00:44:27]

On 2016/01/09 00:43:00, Lei Zhang wrote:
> On 2016/01/09 00:35:53, Tom Sepez wrote:
> > I only reviewed the xfa/ files.
> 
> There's xfa-only changes outside of xfa/
Ok, Looking.

[Tom Sepez, 2016-01-09 00:48:12]

Otherwise looks good.  Let me know what you want to do about the one block that
scares me.

https://codereview.chromium.org/1577503002/diff/20001/core/src/fxcodec/lbmp/f...
File core/src/fxcodec/lbmp/fx_bmp.cpp (right):

https://codereview.chromium.org/1577503002/diff/20001/core/src/fxcodec/lbmp/f...
core/src/fxcodec/lbmp/fx_bmp.cpp:93: ASSERT(sizeof(BmpCoreHeader) ==
kBmpCoreHeaderSize);
nit: static_assert

[Lei Zhang, 2016-01-09 01:00:15]

Does patch set 3 look better?

[Tom Sepez, 2016-01-11 17:23:56]

lgtm

[Lei Zhang, 2016-01-11 19:59:26]

Description was changed from

==========
Merge to XFA: Switch most min/max macros to std::min/max.

Fix lint errors along the way.

TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1567343002 .

(cherry picked from commit 9adfbb0920a258e916003b1ee9515e97879db82a)
==========

to

==========
Merge to XFA: Switch most min/max macros to std::min/max.

Fix lint errors along the way.

R=tsepez@chromium.org
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1567343002 .

(cherry picked from commit 9adfbb0920a258e916003b1ee9515e97879db82a)

Committed:
https://pdfium.googlesource.com/pdfium/+/375a86403b7fa8d17d7b142c270e2d8e33bb...
==========

[Lei Zhang, 2016-01-11 19:59:27]

Committed patchset #4 (id:60001) manually as
375a86403b7fa8d17d7b142c270e2d8e33bb924f (presubmit successful).