Switch most min/max macros to std::min/max.

Switch most min/max macros to std::min/max.

Fix lint errors along the way.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/9adfbb0920a258e916003b1ee9515e97879db82a

[Lei Zhang, 2016-01-08 05:33:00]

Description was changed from

==========
Switch most min/max macros to std::min/max.
==========

to

==========
Switch most min/max macros to std::min/max.

Fix lint errors along the way.
==========

[Lei Zhang, 2016-01-08 05:33:00]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-01-08 17:54:43]

lgtm

https://codereview.chromium.org/1567343002/diff/60001/core/src/fpdftext/fpdf_...
File core/src/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/1567343002/diff/60001/core/src/fpdftext/fpdf_...
core/src/fpdftext/fpdf_text_int.cpp:1927: if (nChars == 1 && (0x2D == curChar ||
0xAD == curChar) &&
nit: the (0x2D == curChar || 0xAD == curChar) is repeated in a few places in
this file, probably should be a helper.  0x2D is a dash, U+00AD is a hypen, so
I'm not sure how this relates to the existing ishypen() method. For next time.

https://codereview.chromium.org/1567343002/diff/60001/core/src/fxcrt/extension.h
File core/src/fxcrt/extension.h (right):

https://codereview.chromium.org/1567343002/diff/60001/core/src/fxcrt/extensio...
core/src/fxcrt/extension.h:40: ~CFX_CRTFileStream() override {
nit: discourage implementing virtual methods in headers.  Next time.

https://codereview.chromium.org/1567343002/diff/60001/core/src/fxcrt/extensio...
core/src/fxcrt/extension.h:233: FX_Alloc(uint8_t, std::max(nInitSize,
static_cast<size_t>(4096)));
nit: maybe just 4096u ?

https://codereview.chromium.org/1567343002/diff/60001/fpdfsdk/src/fpdf_flatte...
File fpdfsdk/src/fpdf_flatten.cpp (right):

https://codereview.chromium.org/1567343002/diff/60001/fpdfsdk/src/fpdf_flatte...
fpdfsdk/src/fpdf_flatten.cpp:305: FX_FLOAT left = std::min(std::min(x1, x2),
std::min(x3, x4));
nit: I guess std::min({x1, x2, x3, x4}) is still banned?

[Lei Zhang, 2016-01-08 23:29:53]

https://codereview.chromium.org/1567343002/diff/60001/core/src/fpdftext/fpdf_...
File core/src/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/1567343002/diff/60001/core/src/fpdftext/fpdf_...
core/src/fpdftext/fpdf_text_int.cpp:1927: if (nChars == 1 && (0x2D == curChar ||
0xAD == curChar) &&
On 2016/01/08 17:54:43, Tom Sepez wrote:
> nit: the (0x2D == curChar || 0xAD == curChar) is repeated in a few places in
> this file, probably should be a helper.  0x2D is a dash, U+00AD is a hypen, so
> I'm not sure how this relates to the existing ishypen() method. For next time.

Acknowledged.

https://codereview.chromium.org/1567343002/diff/60001/core/src/fxcrt/extension.h
File core/src/fxcrt/extension.h (right):

https://codereview.chromium.org/1567343002/diff/60001/core/src/fxcrt/extensio...
core/src/fxcrt/extension.h:40: ~CFX_CRTFileStream() override {
On 2016/01/08 17:54:43, Tom Sepez wrote:
> nit: discourage implementing virtual methods in headers.  Next time.

Moved all of CFX_CRTFileStream's impl.

https://codereview.chromium.org/1567343002/diff/60001/core/src/fxcrt/extensio...
core/src/fxcrt/extension.h:233: FX_Alloc(uint8_t, std::max(nInitSize,
static_cast<size_t>(4096)));
On 2016/01/08 17:54:43, Tom Sepez wrote:
> nit: maybe just 4096u ?

No, std::min/max still doesn't like size_t vs unsigned $something.

https://codereview.chromium.org/1567343002/diff/60001/fpdfsdk/src/fpdf_flatte...
File fpdfsdk/src/fpdf_flatten.cpp (right):

https://codereview.chromium.org/1567343002/diff/60001/fpdfsdk/src/fpdf_flatte...
fpdfsdk/src/fpdf_flatten.cpp:305: FX_FLOAT left = std::min(std::min(x1, x2),
std::min(x3, x4));
On 2016/01/08 17:54:43, Tom Sepez wrote:
> nit: I guess std::min({x1, x2, x3, x4}) is still banned?

Don't see it on the allowed list.

[Lei Zhang, 2016-01-08 23:31:54]

Description was changed from

==========
Switch most min/max macros to std::min/max.

Fix lint errors along the way.
==========

to

==========
Switch most min/max macros to std::min/max.

Fix lint errors along the way.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/9adfbb0920a258e916003b1ee9515e97879d...
==========

[Lei Zhang, 2016-01-08 23:31:55]

Committed patchset #7 (id:120001) manually as
9adfbb0920a258e916003b1ee9515e97879db82a (presubmit successful).