[turbofan] Fix double reduce in escape analysis

[turbofan] Fix double reduce in escape analysis

The escape analysis transformation phase visits allocation nodes
twice under some circumstances, thus reporting wrong counter values.
This CL ensures counter values are correct.

R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n

Committed: https://crrev.com/a3f234cd55ebaeedda33bdac8003e7fa6f13ebaa
Cr-Commit-Position: refs/heads/master@{#33270}

[sigurds, 2016-01-12 09:48:51]

Description was changed from

==========
[turbofan] Fix double reduce in escape analysis

The escape analysis transformation phase visits allocation nodes
twice under some cirmumstances, thus reporting wrong counter numbers.
This CL ensures counter values are correct.


R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Fix double reduce in escape analysis

The escape analysis transformation phase visits allocation nodes
twice under some cirmumstances, thus reporting wrong counter values.
This CL ensures counter values are correct.


R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

[sigurds, 2016-01-12 10:07:17]

PTAL

[Michael Starzinger, 2016-01-12 12:25:00]

LGTM.

https://codereview.chromium.org/1577273002/diff/1/src/compiler/escape-analysi...
File src/compiler/escape-analysis-reducer.cc (right):

https://codereview.chromium.org/1577273002/diff/1/src/compiler/escape-analysi...
src/compiler/escape-analysis-reducer.cc:59: visited_.Add(node->id());
nit: Why add the node twice?

[sigurds, 2016-01-13 15:32:56]

Description was changed from

==========
[turbofan] Fix double reduce in escape analysis

The escape analysis transformation phase visits allocation nodes
twice under some cirmumstances, thus reporting wrong counter values.
This CL ensures counter values are correct.


R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Fix double reduce in escape analysis

The escape analysis transformation phase visits allocation nodes
twice under some circumstances, thus reporting wrong counter values.
This CL ensures counter values are correct.


R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

[sigurds, 2016-01-13 15:33:04]

The CQ bit was checked by sigurds@chromium.org

[commit-bot: I haz the power, 2016-01-13 15:33:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1577273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1577273002/1

[commit-bot: I haz the power, 2016-01-13 16:03:27]

Description was changed from

==========
[turbofan] Fix double reduce in escape analysis

The escape analysis transformation phase visits allocation nodes
twice under some circumstances, thus reporting wrong counter values.
This CL ensures counter values are correct.


R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Fix double reduce in escape analysis

The escape analysis transformation phase visits allocation nodes
twice under some circumstances, thus reporting wrong counter values.
This CL ensures counter values are correct.


R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

[commit-bot: I haz the power, 2016-01-13 16:03:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-13 16:03:45]

Description was changed from

==========
[turbofan] Fix double reduce in escape analysis

The escape analysis transformation phase visits allocation nodes
twice under some circumstances, thus reporting wrong counter values.
This CL ensures counter values are correct.


R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Fix double reduce in escape analysis

The escape analysis transformation phase visits allocation nodes
twice under some circumstances, thus reporting wrong counter values.
This CL ensures counter values are correct.

R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n

Committed: https://crrev.com/a3f234cd55ebaeedda33bdac8003e7fa6f13ebaa
Cr-Commit-Position: refs/heads/master@{#33270}
==========

[commit-bot: I haz the power, 2016-01-13 16:03:45]

Patchset 1 (id:??) landed as
https://crrev.com/a3f234cd55ebaeedda33bdac8003e7fa6f13ebaa
Cr-Commit-Position: refs/heads/master@{#33270}