[turbofan] Performance enhancements for escape analysis

[turbofan] Various performance enhancements for escape analysis

This bug improves performance of escape analysis.

* A allocation discovery phase  (EscapeAnalysis::AssignAliases)
  ensures compact representation of virtual state
* Node revisiting in EscapeStatusAnalysis has been improved
* Escape analysis no longer requires a trimmed graph

BUG=v8:4586
LOG=n

Committed: https://crrev.com/fc9a73e8a63e46d3c402b0b1dd9a4f01901111b3
Cr-Commit-Position: refs/heads/master@{#33267}

[sigurds, 2016-01-11 12:04:53]

Description was changed from

==========
[turbofan] Various performance enhancements for escape analysis

BUG=
==========

to

==========
[turbofan] Various performance enhancements for escape analysis

This bug improves performance of escape analysis.

* A allocation discovery phase (EscapeAnalysis::AssignAliases) ensures compact
representation of virtual state
* Node revisiting in EscapeStatusAnalysis has been improved
* Escape analysis no longer requires a trimmed graph

BUG=v8:4586
LOG=n
==========

[sigurds, 2016-01-11 12:04:53]

sigurds@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[sigurds, 2016-01-11 12:05:10]

Description was changed from

==========
[turbofan] Various performance enhancements for escape analysis

This bug improves performance of escape analysis.

* A allocation discovery phase (EscapeAnalysis::AssignAliases) ensures compact
representation of virtual state
* Node revisiting in EscapeStatusAnalysis has been improved
* Escape analysis no longer requires a trimmed graph

BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Various performance enhancements for escape analysis

This bug improves performance of escape analysis.

* A allocation discovery phase  (EscapeAnalysis::AssignAliases) ensures compact 
  representation of virtual state
* Node revisiting in EscapeStatusAnalysis has been improved
* Escape analysis no longer requires a trimmed graph

BUG=v8:4586
LOG=n
==========

[sigurds, 2016-01-11 12:05:25]

Description was changed from

==========
[turbofan] Various performance enhancements for escape analysis

This bug improves performance of escape analysis.

* A allocation discovery phase  (EscapeAnalysis::AssignAliases) ensures compact 
  representation of virtual state
* Node revisiting in EscapeStatusAnalysis has been improved
* Escape analysis no longer requires a trimmed graph

BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Various performance enhancements for escape analysis

This bug improves performance of escape analysis.

* A allocation discovery phase  (EscapeAnalysis::AssignAliases) 
  ensures compact representation of virtual state
* Node revisiting in EscapeStatusAnalysis has been improved
* Escape analysis no longer requires a trimmed graph

BUG=v8:4586
LOG=n
==========

[sigurds, 2016-01-11 12:05:59]

PTAL

[Michael Starzinger, 2016-01-12 17:27:44]

LGTM, only nits.

https://codereview.chromium.org/1559123003/diff/190006/src/compiler/escape-an...
File src/compiler/escape-analysis.cc (right):

https://codereview.chromium.org/1559123003/diff/190006/src/compiler/escape-an...
src/compiler/escape-analysis.cc:7: #include "src/compiler/escape-analysis.h"
nit: Let's keep the "escape-analysis.h" include at the top as per style-guide
recommendation.

https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

https://codereview.chromium.org/1559123003/diff/190006/src/compiler/escape-an...
src/compiler/escape-analysis.cc:480: status_[node->id()] =
EscapeStatusFlags(status_[node->id()] & ~kOnStack);
nit: Would "status_[node->id()] &= ~kOnStack" do the trick here?

https://codereview.chromium.org/1559123003/diff/190006/src/compiler/escape-an...
src/compiler/escape-analysis.cc:767: } break;
nit: Funny formatting, I actually like it, but V8 uses different style.

https://codereview.chromium.org/1559123003/diff/190006/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (left):

https://codereview.chromium.org/1559123003/diff/190006/src/compiler/pipeline....
src/compiler/pipeline.cc:1169: Run<EarlyGraphTrimmingPhase>();
Woot, I like it!

[sigurds, 2016-01-13 14:59:05]

The CQ bit was checked by sigurds@chromium.org

[sigurds, 2016-01-13 14:59:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1559123003/#ps270001
(title: "Fix fix")

[commit-bot: I haz the power, 2016-01-13 14:59:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559123003/270001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559123003/270001

[commit-bot: I haz the power, 2016-01-13 15:30:17]

Description was changed from

==========
[turbofan] Various performance enhancements for escape analysis

This bug improves performance of escape analysis.

* A allocation discovery phase  (EscapeAnalysis::AssignAliases) 
  ensures compact representation of virtual state
* Node revisiting in EscapeStatusAnalysis has been improved
* Escape analysis no longer requires a trimmed graph

BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Various performance enhancements for escape analysis

This bug improves performance of escape analysis.

* A allocation discovery phase  (EscapeAnalysis::AssignAliases) 
  ensures compact representation of virtual state
* Node revisiting in EscapeStatusAnalysis has been improved
* Escape analysis no longer requires a trimmed graph

BUG=v8:4586
LOG=n
==========

[commit-bot: I haz the power, 2016-01-13 15:30:18]

Committed patchset #15 (id:270001)

[commit-bot: I haz the power, 2016-01-13 15:30:53]

Description was changed from

==========
[turbofan] Various performance enhancements for escape analysis

This bug improves performance of escape analysis.

* A allocation discovery phase  (EscapeAnalysis::AssignAliases) 
  ensures compact representation of virtual state
* Node revisiting in EscapeStatusAnalysis has been improved
* Escape analysis no longer requires a trimmed graph

BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Various performance enhancements for escape analysis

This bug improves performance of escape analysis.

* A allocation discovery phase  (EscapeAnalysis::AssignAliases)
  ensures compact representation of virtual state
* Node revisiting in EscapeStatusAnalysis has been improved
* Escape analysis no longer requires a trimmed graph

BUG=v8:4586
LOG=n

Committed: https://crrev.com/fc9a73e8a63e46d3c402b0b1dd9a4f01901111b3
Cr-Commit-Position: refs/heads/master@{#33267}
==========

[commit-bot: I haz the power, 2016-01-13 15:30:54]

Patchset 15 (id:??) landed as
https://crrev.com/fc9a73e8a63e46d3c402b0b1dd9a4f01901111b3
Cr-Commit-Position: refs/heads/master@{#33267}