Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1577243002: setRangeText shouldn't dispatch 'search' event. (Closed)

Created:
4 years, 11 months ago by tkent
Modified:
4 years, 11 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

setRangeText shouldn't dispatch 'search' event. We should not call subtreeHasChanged() in HTMLTextFormControlElement::setRangeText. BUG=576454 TEST=automated Committed: https://crrev.com/6fc1fb1df9c95847b93feee09819981cbac71eb1 Cr-Commit-Position: refs/heads/master@{#368841}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
tkent
Keishi, would you review this please?
4 years, 11 months ago (2016-01-12 07:07:17 UTC) #2
keishi
LGTM
4 years, 11 months ago (2016-01-12 08:48:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577243002/1
4 years, 11 months ago (2016-01-12 08:50:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 09:57:29 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 09:58:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fc1fb1df9c95847b93feee09819981cbac71eb1
Cr-Commit-Position: refs/heads/master@{#368841}

Powered by Google App Engine
This is Rietveld 408576698